Update jquery.infinite-pages.js.coffee for turbolinks #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix caching issue with turbolinks
| # Constructs the new InfinitePages object | ||
| # | ||
| # container - the element containing the infinite table and pagination links | ||
| constructor: (container, options) -> | ||
| @options = $.extend({}, @defaults, options) | ||
| @$container = $(container) | ||
| @container = '.'+container.className; |
There was a problem hiding this comment.
This introduces new dependencies on the container argument. With your change it look like it has to be a DOM element with a class name instead of a jQuery CSS selector
There was a problem hiding this comment.
Your right, it would take more work to make it a generic selector.
zmillman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue where if you went off the page with the infinite scrolling and back on the scrolling was broken because the next link was cached.
I created a sample app https://github.com/hwatkins/endless_kaminari with turbolinks enabled to show how it works.
I'm not an expert at javascript or coffeescript so there may be a better way, but this worked for me.