Merge pull request #20 from mailgun/dietz/REP-937

Requests over remaining shouldn't change remaining
mailgun · Oct 29, 2019 · b347f24 · b347f24
2 parents 4e0a902 + 08f8411
commit b347f24
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/algorithms.go b/algorithms.go
@@ -77,7 +77,7 @@ func tokenBucket(c cache.Cache, r *RateLimitReq) (*RateLimitResp, error) {
 	// Client could be requesting that we always return OVER_LIMIT
 	if r.Hits > r.Limit {
 		status.Status = Status_OVER_LIMIT
-		status.Remaining = 0
+		status.Remaining = r.Limit
 	}
 
 	c.Add(r.HashKey(), status, expire)

diff --git a/cache/lru.go b/cache/lru.go
@@ -146,6 +146,10 @@ func (c *LRUCache) Size() int {
 	return c.ll.Len()
 }
 
+func (c *LRUCache) Stats(_ bool) Stats {
+	return c.stats
+}
+
 // Update the expiration time for the key
 func (c *LRUCache) UpdateExpiration(key Key, expireAt int64) bool {
 	if ele, hit := c.cache[key]; hit {