Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(routing): use PatchWithRetry #81

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(routing): use PatchWithRetry #81

wants to merge 3 commits into from

Conversation

cam-garrison
Copy link
Collaborator

Summary:

  • Introduces unstruct.PatchWithRetry using controllerutil.CreateOrPatch for conflict-resistant updates
  • Refactors finalizer management and host propagation to use the new retry mechanism
  • Removes unnecessary unstruct.Patch call from the main Reconcile function, instead moving PatchWithRetry calls to where they are needed.

@cam-garrison
Copy link
Collaborator Author

Pulled the changes out of #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslakknutsen aslakknutsen aslakknutsen approved these changes

@bartoszmajsak bartoszmajsak Awaiting requested review from bartoszmajsak

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cam-garrison @aslakknutsen @bartoszmajsak