Tech 1677 #20
Merged
Tech 1677 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeannettemcd
requested review from
eskp,
OleksandrUA,
zdumitru,
cristidas,
nickkounz and
sanbotto
|
|
jeannettemcd
force-pushed
the
TECH-1677
branch
from
b76817b to
9326591
Compare
nickkounz
reviewed
Oct 24, 2023
chief_keeper/chief_keeper.py
Outdated
| from pymaker.keys import register_keys | ||
| from pymaker.lifecycle import Lifecycle | ||
| from pymaker.deployment import DssDeployment | ||
|
|
||
| from auction_keeper.gas import DynamicGasPrice | ||
| # from auction_keeper.gas import DynamicGasPrice |
There was a problem hiding this comment.
The auction_keeper library was removed completely, it is not needed with the new gas strategy
There was a problem hiding this comment.
yeah - I was thinking whether you want to delete this line rather than comment it out?
nickkounz
reviewed
Oct 24, 2023
nickkounz
reviewed
Oct 24, 2023
nickkounz
reviewed
Oct 24, 2023
nickkounz
reviewed
Oct 24, 2023
nickkounz
reviewed
Oct 24, 2023
nickkounz
reviewed
Oct 24, 2023
nickkounz
reviewed
Oct 24, 2023
nickkounz
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented chief-keeper to use GeoMetric gas strategy for better response to rising gas prices.