Simplify overflow check for squaring in rpow(x,n,base)

makerdao · Oct 19, 2019 · f71cd48 · f71cd48
1 parent aaad4df
commit f71cd48
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/jug.sol b/src/jug.sol
@@ -47,7 +47,7 @@ contract Jug is DSNote {
                     let half := div(b, 2)  // for rounding.
                     for { n := div(n, 2) } n { n := div(n,2) } {
                         let xx := mul(x, x)
-                        if iszero(eq(div(xx, x), x)) { revert(0,0) }
+                        if shr(128, x) { revert(0,0) }
                         let xxRound := add(xx, half)
                         if lt(xxRound, xx) { revert(0,0) }
                         x := div(xxRound, b)

diff --git a/src/pot.sol b/src/pot.sol
@@ -85,7 +85,7 @@ contract Pot is DSNote {
                     let half := div(base, 2)  // for rounding.
                     for { n := div(n, 2) } n { n := div(n,2) } {
                         let xx := mul(x, x)
-                        if iszero(eq(div(xx, x), x)) { revert(0,0) }
+                        if shr(128, x) { revert(0,0) }
                         let xxRound := add(xx, half)
                         if lt(xxRound, xx) { revert(0,0) }
                         x := div(xxRound, base)