Supply Sync #16
Draft
Supply Sync #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldchili
force-pushed
the
supply-sync
branch
from
936569d to
6b6a887
Compare
oldchili
commented
Nov 19, 2024
src/SupplySync.sol
Outdated
|
|
||
| /// MkrSky.sol -- Mkr/Sky Exchanger | ||
|
|
||
| // Copyright (C) 2023 Dai Foundation |
src/SupplySync.sol
Outdated
| GemLike public immutable mkr; | ||
| GemLike public immutable sky; | ||
|
|
||
| constructor(address mkr_, address sky_, address owner) { |
There was a problem hiding this comment.
Considering the converter doesn't have the conversion value hardcoded, I wouldn't do it here. My suggestion would be to actually pass the converter as the constructor param, and then you have the 3 values.
src/SupplySync.sol
Outdated
| unchecked { | ||
| if (mkrSupplyInSky > skyBalance) { | ||
| sky.mint(address(this), mkrSupplyInSky - skyBalance); | ||
| } else { |
There was a problem hiding this comment.
I think I'd prefer an elseif, so we avoid to burn 0 if sync is called multiple times. But it is really a very subjective thing, not really important gas wise.
There was a problem hiding this comment.
ok, changed to that and also added return values so it's easier to use it in a bot/cron-job.
telome
reviewed
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.