[FR-206] Change validation code from Integer to String #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation code used to verify gift cards are in 16 digit hex. Hence the field needed to be String(16) to store it.
|
I believe 0025 migrations has not been applied/deployed yet. |
emanuelen5
reviewed
Dec 7, 2023
| @@ -2,7 +2,7 @@ | |||
| CREATE TABLE IF NOT EXISTS `webshop_gift_card`( | |||
| `id` int(11) unsigned NOT NULL AUTO_INCREMENT, | |||
| `amount` decimal(15,2) NOT NULL, | |||
| `validation_code` int(10) unsigned NOT NULL, | |||
| `validation_code` VARCHAR(16) COLLATE utf8mb4_0900_ai_ci NOT NULL, | |||
There was a problem hiding this comment.
Isn't the validation_code missing a UNIQUE constraint?
BerglundDaniel
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation code used to verify gift cards are in 16 digit hex. Hence the field needed to be String(16) to store it.