Improve threading when calling the accessy api. #585
Merged
+20
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe pull request introduces modifications to the Changes
Sequence DiagramsequenceDiagram
participant Client
participant AccessyAPI
participant ThreadPool
Client->>ThreadPool: Divide user IDs into chunks
loop Process Chunks
ThreadPool->>AccessyAPI: Fetch user details
AccessyAPI-->>ThreadPool: Return user membership
end
ThreadPool-->>Client: Consolidated user data
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
api/src/multiaccessy/accessy.py (2)
60-68: LGTM! Backoff strategy improvements look good.The changes to the backoff strategy are well thought out:
- Lower initial backoff allows for quicker retry attempts
- Fixed multiplier provides predictable exponential backoff
- Random factor helps prevent thundering herd problem
Fix typo in warning message
There's a typo in "reqeusts" in the warning message.
- f"requesting accessy returned 429, too many reqeusts, try {i+1}/{max_tries}, retrying in {backoff}s, {path=}" + f"requesting accessy returned 429, too many requests, try {i+1}/{max_tries}, retrying in {backoff}s, {path=}"
545-561: LGTM! Threading model improvements significantly reduce thread count.The new implementation effectively addresses the rate limiting issues by:
- Limiting maximum thread count to 4
- Chunking user IDs across threads
- Using round-robin distribution for balanced load
Consider these enhancements to the threading implementation
- Make the thread count configurable via environment variable
- Add error handling in the worker function
- Consider using ThreadPoolExecutor for better thread management
+MAX_THREADS = int(config.get("ACCESSY_MAX_THREADS", default="4")) + def _user_ids_to_accessy_members(self, user_ids: Iterable[UUID]) -> list[AccessyMember]: threads = [] user_ids = list(user_ids) - thread_count = min(4, len(user_ids)) + thread_count = min(MAX_THREADS, len(user_ids)) accessy_members = [] for i in range(thread_count): slice = user_ids[i::thread_count] member_slice = [AccessyMember(user_id=uid) for uid in slice] accessy_members.extend(member_slice) def worker(member_slice: list[AccessyMember]) -> None: - for member in member_slice: - fill_user_details(member) - fill_membership_id(member) + try: + for member in member_slice: + fill_user_details(member) + fill_membership_id(member) + except Exception as e: + logger.error(f"Error processing members: {e}") + raise t = threading.Thread(target=worker, args=(member_slice,)) threads.append(t) t.start()Alternative implementation using ThreadPoolExecutor:
from concurrent.futures import ThreadPoolExecutor, as_completed def _user_ids_to_accessy_members(self, user_ids: Iterable[UUID]) -> list[AccessyMember]: user_ids = list(user_ids) thread_count = min(MAX_THREADS, len(user_ids)) accessy_members = [] def process_chunk(chunk: list[UUID]) -> list[AccessyMember]: members = [AccessyMember(user_id=uid) for uid in chunk] for member in members: fill_user_details(member) fill_membership_id(member) return members # Split user_ids into chunks chunks = [user_ids[i::thread_count] for i in range(thread_count)] with ThreadPoolExecutor(max_workers=thread_count) as executor: futures = [executor.submit(process_chunk, chunk) for chunk in chunks] for future in as_completed(futures): try: chunk_members = future.result() accessy_members.extend(chunk_members) except Exception as e: logger.error(f"Error processing members: {e}") raise # Filter out API keys accessy_members = [m for m in accessy_members if m.phone is not APPLICATION_PHONE_NUMBER] return accessy_members
HalfVoxel
force-pushed
the
aron/accessy_threading
branch
from
33e5c40 to
2729ca1
Compare
emanuelen5
approved these changes
Dec 19, 2024
|
I fixed the build so you can now rebase on main to get the tests running. |
| @@ -541,14 +542,23 @@ def fill_membership_id(user: AccessyMember) -> None: | |||
| user.membership_id = data["id"] | |||
|
|
|||
| threads = [] | |||
| user_ids = list(user_ids) | |||
| thread_count = min(4, len(user_ids)) | |||
There was a problem hiding this comment.
I don't follow this completely. Doesn't this still create one thread per user_id as before?
There was a problem hiding this comment.
No, it creates at most 4 threads.
The previous code started one thread per member, which is way too much, and just resulted in a ton of rate limit errors.
HalfVoxel
force-pushed
the
aron/accessy_threading
branch
from
2729ca1 to
533c111
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code started one thread per member, which is way too much, and just resulted
in a ton of rate limit errors.
Summary by CodeRabbit
New Features
Bug Fixes