-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init add of Xamarin rules #824
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
0f6fd76
to
8c86693
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so cool to see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the testfiles should be separate.
Similarly, do we want to keep the rules files separate? Some rules contain various formats/OS so that's a little messy.
There's pro and cons, so maybe we better open up a separate discussion?
Collecting my thoughts here but happy to spin off separate issues/discussions.
related discussion: mandiant/capa#701 (Rule organization for multiple file types PE and ELF) |
…get-os-version-in-dotnet-on-android.yml
Adding new rules based on #706 . This PR may be impacted by the discussions in #818 regarding mobile ATT&CK techniques. I wanted to open a PR for discussion before diving too far into creating new rules.
Questions: