Update and refactor memory allocation/permission rules #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-tz
commented
Oct 11, 2023
There was a problem hiding this comment.
now named: allocate or change RWX memory
lib/allocate-rw-memory.yml
Outdated
There was a problem hiding this comment.
now called: allocate or change RW memory
Comment on lines
-19
to
-26
| - api: kernel32.VirtualProtect | ||
| - api: kernel32.VirtualProtectEx | ||
| - api: NtAllocateVirtualMemory | ||
| - api: ZwAllocateVirtualMemory | ||
| - api: NtMapViewOfSection | ||
| - api: ZwMapViewOfSection | ||
| - api: NtProtectVirtualMemory | ||
| - api: ZwProtectVirtualMemory |
There was a problem hiding this comment.
moved the removed APIs to change memory protection
There was a problem hiding this comment.
this is a nice cleanup
Comment on lines
-16
to
-28
| - basic block: | ||
| - and: | ||
| # xor ecx, ecx ; lpAddress | ||
| # mov edx, 31Fh ; dwSize | ||
| # mov r8d, 1000h ; flAllocationType | ||
| # lea r9d, [rcx+40h] ; flProtect | ||
| # call cs:VirtualAlloc | ||
| - match: allocate memory | ||
| - or: | ||
| - number: 0x40 | ||
| - instruction: | ||
| - mnemonic: lea | ||
| - offset: 0x40 |
There was a problem hiding this comment.
moved to allocate RWX memory / allocate RW memory
|
@jtothej feel free to review and provide feedback here, as well |
williballenthin
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
this is a beautiful update that really shows how we can abstract logic with capa. thanks @mr-tz !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per the comments in #798 / https://github.com/mandiant/capa-rules/pull/798/files#r1264358655