Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Property Feature. #1116

Closed
wants to merge 1 commit into from

Conversation

adamstorek
Copy link

@adamstorek adamstorek commented Jul 21, 2022

Adding a property feature that represents a class attribute access as discussed in #1110.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed

@mike-hunhoff mike-hunhoff added the dont merge Indicate a PR that is still being worked on label Aug 1, 2022
@mr-tz
Copy link
Collaborator

mr-tz commented Aug 8, 2022

covered in #1122? do we need the duplicate here?

@adamstorek
Copy link
Author

covered in #1122? do we need the duplicate here?

It's also covered in #1080, but @mike-hunhoff wanted me to create a separate pull request for the property feature.

@mike-hunhoff
Copy link
Collaborator

We had two projects (#1080 and #1122) developing this code so to avoid duplicating work we asked @adamstorek to open a PR containing his implementation. This allowed both projects to move forward with a single implementation. Once v4 is released we can merge this PR so both projects are up-to-date w/ master.

@mr-tz
Copy link
Collaborator

mr-tz commented Aug 8, 2022

ah, gotcha!

@mike-hunhoff
Copy link
Collaborator

This PR is outdated due to recent changes resulting from #1142 . Required updates were made to #1168 branched from #1122 branched from here so we are closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont merge Indicate a PR that is still being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants