Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BinExport2: better handle weird expression trees #2531

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

williballenthin
Copy link
Collaborator

closes #2528 #2530

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

@williballenthin williballenthin added bug Something isn't working binexport related to BinExport support labels Dec 9, 2024
@williballenthin williballenthin requested a review from mr-tz December 9, 2024 10:03
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed

@github-actions github-actions bot dismissed their stale review December 9, 2024 10:04

CHANGELOG updated or no update needed, thanks! 😄

analogous to the inspect-binexport2 issues reported in #2528 and #2530,
but this fixes the feature extractor.
@williballenthin williballenthin merged commit 5c60ada into master Dec 9, 2024
19 checks passed
@williballenthin williballenthin deleted the fix/issue-2528 branch December 9, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binexport related to BinExport support bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BinExport assertion fail for register (unexpected child expression)
2 participants