Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSoC'23 Project: Implement an Interactive GUI for presenting Network-Based Indicators summary #163
GSoC'23 Project: Implement an Interactive GUI for presenting Network-Based Indicators summary #163
Changes from 6 commits
2f5119a
81f9fe5
77205df
8dcad9d
e4b22a7
1638d51
77945b9
770a6ee
24f1c54
c3d63b1
73c72de
8cd483c
e4be3fb
afb32fa
5d2b187
bc9e6a8
ca9f992
fe24a6d
5a63b7d
59964a8
7a55b15
5fff6b3
f20c990
4f42b25
a4f6348
8c9b6e4
d5463df
1b7944a
3afda5c
3ed2a77
2254673
b5f1070
be1eae2
252e7ac
a60893e
c82b3b6
e401d3f
730c5dc
3b9693a
dc45936
9ee0950
6a2c20e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like us to document (via comments) why there must exist both a run() and a connect() method.
Your astute mentor reminded me that we documented this in our discussion notes:
Maintainers would benefit from seeing this represented in the comments for connect() along with commentary on the run() method indicating the expectation that connect() has already been called.