Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoders improvements 3 - another batch #46

Merged
merged 4 commits into from
Dec 21, 2024

Conversation

jrouaix
Copy link
Contributor

@jrouaix jrouaix commented Dec 16, 2024

just some more refacto, mainly on network & opendirectory modules

@jrouaix jrouaix changed the title Decoders improvments3 - another batch Decoders improvements 3 - another batch Dec 17, 2024
Copy link
Collaborator

@puffyCid puffyCid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!
Left few comments for very small clippy nitpicks

src/util.rs Show resolved Hide resolved
src/decoders/network.rs Outdated Show resolved Hide resolved
@jrouaix
Copy link
Contributor Author

jrouaix commented Dec 18, 2024

Should be good now, paired with clippy

@puffyCid puffyCid merged commit 7d132c4 into mandiant:main Dec 21, 2024
4 checks passed
@jrouaix jrouaix deleted the decoders_improvments3 branch December 26, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants