Improve user experience #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuiMacielPereira
added
enhancement
Previously the range in tof to be masked was being specified by ','. It makes more sense to use '-' to describe the range.
Previously the workspaces for the y-space fit were being overwritten when the fitting model changed. This change changes the name of the workspace which makes sure the workspaces do not get overwritten.
Save some plots by default that were not being saved
Added function to save workspaces containing the result in y space fit in Ascii format, and made minor esthetic improvements to plots that are also saved.
GuiMacielPereira
force-pushed
the
better-user-experience
branch
from
a97f056 to
6e733e9
Compare
Re-running y-space fit with subtraction of fse turned on was picking up the wrong workspace that also ended in 'fse'. This correction guarantees the right workspace is chosen.
SilkeSchomann
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
When running the analysis script with different fitting models, previous workspaces are not overwritten anymore. Also, the naming makes it easy to match output files to the corresponding fitting model. The variable names are now easier to understand and there are some new useful comments, especially in the input sections of the different analysis algorithms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work:
To test:
Code review
+
Manual testing:
Activate an environment with mantidworkbench installed:
pip install -e .~/.mvesuviomvesuvio config, this should create a new~/.mvesuvio~/.mvesuvio/analysis_inputs.pyForwardAnalysisInputschange the fieldmask_time_of_flight_range = '112-120'analysis_inputs_fwd_0and check that dataY has zeros in columns between 112 and 120YSpaceFitInputschangefitting_model = "gcc4c6"gaussandgcc4c6fits and the data and the fits should look sensible.~/.mvesuvio/analysis_inputs/figures/and check that figures ending in_fitglobal.pngand_gauss_autominos.pngwere saved._gauss_Workspace.pdfand check that residuals (blue dots) appear in the figure~/.mvesuvio/analysis_inputs/output_files/and check that several ASCII files ending in_Workspaceand_Parameterswere saved.Fixes #145 .