Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Result for directions response #418

Merged
merged 16 commits into from
Apr 4, 2020
Merged

Use Result for directions response #418

merged 16 commits into from
Apr 4, 2020

Conversation

JThramer
Copy link
Contributor

@JThramer JThramer commented Feb 26, 2020 •
edited
Loading

Using Foundation.Result as the base type returned in Directions.calculate. Implements #414. Thanks @SebastianOsinski!

To-Do:

  • Finish fixing tests
  • Update docs

/cc @mapbox/navigation-ios

@JThramer JThramer added backwards incompatible changes that break backwards compatibility of public API op-ex Refactoring, Tech Debt or any other operational excellence work. labels Feb 26, 2020
@JThramer JThramer requested a review from 1ec5 February 26, 2020 05:01
@JThramer JThramer self-assigned this Feb 26, 2020
@JThramer JThramer requested a review from Udumft February 26, 2020 05:01
@JThramer JThramer changed the base branch from master to jerrad/directions-calculate-interface February 26, 2020 05:07
@JThramer JThramer mentioned this pull request Mar 12, 2020
Merged
8 tasks
@1ec5 1ec5 added this to the v1.0.0 milestone Mar 17, 2020
@JThramer JThramer marked this pull request as ready for review April 2, 2020 23:46
@JThramer JThramer requested a review from Udumft April 2, 2020 23:49
@JThramer JThramer requested a review from Udumft April 3, 2020 17:54
@JThramer JThramer changed the base branch from jerrad/directions-calculate-interface to master April 4, 2020 14:43
@JThramer JThramer merged commit c91d3ba into master Apr 4, 2020
@JThramer JThramer deleted the jerrad/directions-use-result branch April 4, 2020 14:43
@1ec5 1ec5 linked an issue Apr 9, 2020 that may be closed by this pull request
Suggestion: Consider using Result instead of optional response and error #414
Closed
This was referenced Apr 9, 2020
Closed
Draft
@1ec5 1ec5 modified the milestones: v1.0.0, v0.31.0 (v0.40) Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Udumft Udumft Udumft approved these changes

@1ec5 1ec5 Awaiting requested review from 1ec5

Assignees

@JThramer JThramer

Labels
backwards incompatible changes that break backwards compatibility of public API op-ex Refactoring, Tech Debt or any other operational excellence work.
Projects
None yet
Milestone
v0.31.0
Development

Successfully merging this pull request may close these issues.

Suggestion: Consider using Result instead of optional response and error
3 participants
@JThramer @Udumft @1ec5