Upgrade to MapboxMaps `v10.4.0-rc.1`, MapboxNavigationNative `v92.0.0`. #3765

MaximAlien · 2022-02-25T02:25:20Z

PR updates dependencies to:

Mapbox Maps v10.4.0-rc.1.
Mapbox Navigation Native v92.0.0.
Mapbox Direction v2.4.0-beta.1.

MaximAlien · 2022-02-25T02:33:33Z

For now we cannot fully update, because of such error:

error: Dependencies could not be resolved because root depends on 'mapbox-navigation-native-ios' 88.0.0..<89.0.0 and root depends on 'mapbox-maps-ios' 10.4.0-beta.1.
'mapbox-maps-ios' is incompatible with 'mapbox-navigation-native-ios' because 'mapbox-maps-ios' >= 10.4.0-beta.1 depends on 'mapbox-common-ios' 21.2.0-beta.1 and 'mapbox-navigation-native-ios' >= 88.0.0 depends on 'mapbox-common-ios' 21.1.0..<22.0.0.

New Mapbox Navigation Native release that contains Mapbox Common v21.2.0-beta.1 will be required.

mapbox-github-ci-issues-public-1 · 2022-03-04T20:53:32Z

No breaking changes detected in MapboxCoreNavigation

mapbox-github-ci-issues-public-1 · 2022-03-04T20:53:35Z

No breaking changes detected in MapboxNavigation

mapbox-github-ci-issues-public-1 · 2022-03-11T07:56:34Z

No breaking changes detected in MapboxCoreNavigation

mapbox-github-ci-issues-public-1 · 2022-03-11T07:56:37Z

No breaking changes detected in MapboxNavigation

mapbox-github-ci-issues-public-1 · 2022-03-11T17:36:33Z

No breaking changes detected in MapboxCoreNavigation

mapbox-github-ci-issues-public-1 · 2022-03-11T17:36:39Z

No breaking changes detected in MapboxNavigation

1ec5 · 2022-03-11T22:36:34Z

The tests pass and turn-by-turn navigation seems to work at first, but route refreshing crashes:

#6	0x00000001038561f0 in closure #1 in InternalRouter<>.refreshRoute(from:legIndex:completion:) at /path/to/mapbox-navigation-ios/Sources/MapboxCoreNavigation/Router.swift:245
#7	0x00000001038576e2 in partial apply for closure #1 in InternalRouter<>.refreshRoute(from:legIndex:completion:) ()
#8	0x00000001037f7a54 in closure #1 in closure #2 in MapboxRoutingProvider.refreshRoute(indexedRouteResponse:fromLegAtIndex:completionHandler:) at /path/to/mapbox-navigation-ios/Sources/MapboxCoreNavigation/MapboxRoutingProvider.swift:316
#9	0x00000001037f4052 in closure #4 in MapboxRoutingProvider.parseResponse<τ_0_0>(requestId:userInfo:result:completion:) at /path/to/mapbox-navigation-ios/Sources/MapboxCoreNavigation/MapboxRoutingProvider.swift:193
#10	0x00000001037f1a1b in closure #1 in MapboxRoutingProvider.complete(requestId:with:) at /path/to/mapbox-navigation-ios/Sources/MapboxCoreNavigation/MapboxRoutingProvider.swift:135

2022-03-11 11:39:53.715232-0800 Example[5739:6593064] nav-native Directions Service: Route refresh request: https://api.mapbox.com/directions-refresh/v1/mapbox/driving-traffic/q1eNQbJc0vTl3bl_VkecBfeUlIQOU1t0P0Y_8dfnnNL9pVqzM2AOVQ==/0/0?access_token=****_9cg
2022-03-11 11:39:53.962849-0800 Example[5739:6598689] nav-native Directions Service: Route refresh response: {"code":"Ok","route":{"legs":[{"annotation":{"maxspeed":[{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"speed":32,"unit":"km/h"},{"speed":32,"unit":"km/h"},{"speed":32,"unit":"km/h"},{"speed":32,"unit":"km/h"},{"speed":32,"unit":"km/h"},{"speed":32,"unit":"km/h"},{"speed":32,"unit":"km/h"},{"speed":32,"unit":"km/h"},{"speed":32,"unit":"km/h"},{"speed":32,"unit":"km/h"},{"speed":32,"unit":"km/h"},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"}],"congestion_numeric":[null,null,null,null,null,null,0,0,0,17,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,0,0,0,0,0,0,0,0,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,0,0,0,8,1,1,1,1,1],"duration":[1.902,2.537,1.844,1.591,1.818,1.657,3.154,5.047,5.047,1.256,0.993,0.61,0.701,0.637,0.839,0.688,0.776,5.155,0.794,0.792,0.86,0.903,0.85,1.027,1.096,1.158,1.356,2.122,0.787,0.97,1.202,1.233,0.937,1.216,0.987,1.185,0.799,0.526,1.047,1.083,1.124,0.528,0.631,0.406,0.452,2.978,3.31,0.593,0.472,0.514,0.526,0.581,0.681,0.729,0.709,0.565,0.536,0.481,0.418,0.361,0.416,0.506,0.368,0.43,0.492,0.51,0.599,0.607,0.571,0.647,0.803,10.003,1.944,2.123,10.426,0.319,5.23,1.177,2.224,0.205]}},{"annotation":{"maxspeed":[{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"unknown":true},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"},{"speed":89,"unit":"km/h"}],"congestion_numeric":[1,1,0,0,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,null,null,null,null,null,null,null,null,null,null,0,0,0,0,0,0,0,0,1,1,0,0,0,0,0,0,0,0,0,0],"duration":[0.952,4.67,12.393,5.822,3.187,4.556,4.151,4.176,0.694,4.233,3.512,2.756,2.75,0.65,0.628,0.445,0.529,0.454,0.387,0.946,0.634,0.607,0.588,0.663,0.594,0.434,0.727,0.592,0.676,0.611,0.886,0.815,0.629,0.59,0.661,1.896,1.895,0.506,0.68,3.558,4.666,13.735,3.568,2.888,4.936,6.323,1.679,5.846,0.382]}}]}}
MapboxCoreNavigation/Router.swift:245: Fatal error: Refreshed `RouteResponse` did not contain required `routeIndex`!
2022-03-11 11:39:54.129591-0800 Example[5739:6592515] MapboxCoreNavigation/Router.swift:245: Fatal error: Refreshed `RouteResponse` did not contain required `routeIndex`!

mapbox-github-ci-issues-public-1 · 2022-03-11T22:39:24Z

No breaking changes detected in MapboxCoreNavigation

mapbox-github-ci-issues-public-1 · 2022-03-11T22:39:27Z

No breaking changes detected in MapboxNavigation

1ec5 · 2022-03-11T22:40:02Z

Sources/MapboxCoreNavigation/RouteController.swift

+        // Based on MBNNRouteIndex.routeId documentation.
+        // FIXME: Distinguish onboard routes with “local@” prefix.
+        let routeResponseIdentifier = indexedRouteResponse.routeResponse.identifier ?? ""
+        let routeIndices = (indexedRouteResponse.routeResponse.routes ?? []).enumerated().map { index, route in
+            RouteIndex(routeId: "\(routeResponseIdentifier)#\(index)", indexInResponse: UInt32(index))
+        }


This route identifier generation code is problematic. The format is hardcoded here based on a documentation comment buried deep in MapboxNavigationNative. There doesn’t seem to be a way to distinguish a remote route from a local route. That was previously by design. We probably need MapboxDirections to persist unrecognized properties in order to have access to the route identifier that the navigator expects: mapbox/mapbox-directions-swift#637. Or is there some other way for this method to determine the source of the route?

/cc @Udumft @SiarheiFedartsou

We introduced Routes.parse API on our side - we will encapsulate this logic there. I tagged you in that PR.

cc @DenisPryt

1ec5 · 2022-03-11T22:40:34Z

Sources/MapboxCoreNavigation/RoutesCoordinator.swift

+        // TODO: Is it safe to set the leg index to 0 when unsetting a route?
+        setRoutes(nil, 0, completion)


Is it safe to set the leg index to 0 when unsetting a route? If not, what should the leg index be in this case?

1ec5 · 2022-03-11T22:41:26Z

Sources/MapboxCoreNavigation/CoreNavigationNavigator.swift

+    func unsetRoutes(uuid: UUID, completion: @escaping (Result<RouteInfo, Error>) -> Void) {
+        routeCoordinator.endActiveNavigation(with: uuid, completion: completion)


I broke out a separate method for unsetting the route, because more than one parameter has different expected values, and the implementation ends up being totally different.

mapbox-github-ci-issues-public-1 · 2022-03-11T22:59:08Z

No breaking changes detected in MapboxCoreNavigation

mapbox-github-ci-issues-public-1 · 2022-03-11T22:59:11Z

No breaking changes detected in MapboxNavigation

Udumft · 2022-03-16T14:41:19Z

Sources/MapboxCoreNavigation/RouteController.swift


-        sharedNavigator.setRoutes(routes, uuid: sessionUUID) { result in
+        sharedNavigator.setRoutes(navigationRoutes, uuid: sessionUUID, legIndex: UInt32(progress.legIndex)) { result in


There is a know issue about setting not first route as primary which results in crash inside NN. Upcoming NN v91 should fix that, as these route handling methods are reworked

mapbox-github-ci-issues-public-1 · 2022-03-17T15:56:10Z

No breaking changes detected in MapboxCoreNavigation

mapbox-github-ci-issues-public-1 · 2022-03-17T15:56:14Z

No breaking changes detected in MapboxNavigation

bamx23 · 2022-03-17T14:54:02Z

Sources/MapboxCoreNavigation/RouteController.swift

+                                                                   request: routeRequest)
+            if parsedRoutes.isValue(),
+               let route = (parsedRoutes.value as? [RouteInterface])?.first {
+                self.sharedNavigator.setRoutes(route, uuid: self.sessionUUID, legIndex: UInt32(progress.legIndex)) { result in


Is it okay to call setRoutes on background queue?

If I’m not mistaken, the expectation is that we’d continue to call this method on the main queue despite calling parseDirectionsResponse(forResponse:) on a background queue.

Navigator is thread-safe(at least it should be), i.e. you can call this method from any thread. The only thing to note is that callbacks will be called on a thread where Navigator was created.

callbacks will be called on a thread where Navigator was created.

So there's not need to explicitly call main thread for the callbacks here (we create Navigator on strictly Main). Will update it

CHANGELOG.md

mapbox-github-ci-issues-public-1 · 2022-03-17T17:19:13Z

No breaking changes detected in MapboxCoreNavigation

mapbox-github-ci-issues-public-1 · 2022-03-17T17:19:18Z

No breaking changes detected in MapboxNavigation

mapbox-github-ci-issues-public-1 · 2022-03-18T02:14:51Z

No breaking changes detected in MapboxCoreNavigation

mapbox-github-ci-issues-public-1 · 2022-03-18T02:14:55Z

No breaking changes detected in MapboxNavigation

mapbox-github-ci-issues-public-1 · 2022-03-18T11:55:02Z

No breaking changes detected in MapboxCoreNavigation

mapbox-github-ci-issues-public-1 · 2022-03-18T11:55:05Z

No breaking changes detected in MapboxNavigation

mapbox-github-ci-issues-public-1 · 2022-03-18T14:19:36Z

Breaking Changes in MapboxCoreNavigation

Breaking API Changes

`NavigationRouteOptions`

removed method: init(locations:profileIdentifier:) in NavigationRouteOptions
removed method: init(waypoints:profileIdentifier:) in NavigationRouteOptions
removed method: init(coordinates:profileIdentifier:) in NavigationRouteOptions

`NavigationMatchOptions`

removed method: init(coordinates:profileIdentifier:) in NavigationMatchOptions
removed method: init(locations:profileIdentifier:) in NavigationMatchOptions
removed method: init(waypoints:profileIdentifier:) in NavigationMatchOptions

mapbox-github-ci-issues-public-1 · 2022-03-18T14:19:39Z

No breaking changes detected in MapboxNavigation

mapbox-github-ci-issues-public-1 · 2022-03-18T16:02:18Z

Breaking Changes in MapboxCoreNavigation

Breaking API Changes

`NavigationMatchOptions`

removed method: init(waypoints:profileIdentifier:) in NavigationMatchOptions
removed method: init(coordinates:profileIdentifier:) in NavigationMatchOptions
removed method: init(locations:profileIdentifier:) in NavigationMatchOptions

`NavigationRouteOptions`

removed method: init(locations:profileIdentifier:) in NavigationRouteOptions
removed method: init(waypoints:profileIdentifier:) in NavigationRouteOptions
removed method: init(coordinates:profileIdentifier:) in NavigationRouteOptions

mapbox-github-ci-issues-public-1 · 2022-03-18T16:02:22Z

No breaking changes detected in MapboxNavigation

mapbox-github-ci-issues-public-1 · 2022-03-18T16:58:39Z

Breaking Changes in MapboxCoreNavigation

Breaking API Changes

`NavigationRouteOptions`

removed method: init(waypoints:profileIdentifier:) in NavigationRouteOptions
removed method: init(locations:profileIdentifier:) in NavigationRouteOptions
removed method: init(coordinates:profileIdentifier:) in NavigationRouteOptions

`NavigationMatchOptions`

removed method: init(waypoints:profileIdentifier:) in NavigationMatchOptions
removed method: init(locations:profileIdentifier:) in NavigationMatchOptions
removed method: init(coordinates:profileIdentifier:) in NavigationMatchOptions

mapbox-github-ci-issues-public-1 · 2022-03-18T16:58:42Z

No breaking changes detected in MapboxNavigation

Udumft · 2022-03-18T17:13:30Z

Breaking changes bot is complaining because listed methods have new argument with a default value. It will not lead to any code updates on user side to adopt this version.

1ec5 · 2022-03-18T18:34:00Z

Sources/MapboxCoreNavigation/NavigationRouteOptions.swift

@@ -17,11 +17,13 @@ open class NavigationRouteOptions: RouteOptions, OptimizedForNavigation {

     - seealso: `RouteOptions`
     */
-    public required init(waypoints: [Waypoint], profileIdentifier: ProfileIdentifier? = .automobileAvoidingTraffic) {
+    public required init(waypoints: [Waypoint], profileIdentifier: ProfileIdentifier? = .automobileAvoidingTraffic, queryItems: [URLQueryItem]? = nil) {


I guess we don’t need to mention this in the changelog, since it’s just an override of the RouteOptions initializer in MapboxDirections, right?

Yes, I think so

1ec5 · 2022-03-18T18:36:25Z

Tests/MapboxNavigationTests/NavigationViewControllerTests.swift

@@ -333,7 +333,7 @@ class NavigationViewControllerTests: TestCase {
                       newRouteResponse.identifier)
    }

-    func testPuck3DLayerPosition() {
+    func disabled_testPuck3DLayerPosition() {


Let’s track reenabling this test in a separate issue.

MaximAlien added the build Issues related to builds and dependency management. label Feb 25, 2022

MaximAlien added this to the v2.4 milestone Feb 25, 2022

MaximAlien requested a review from a team February 25, 2022 02:25

MaximAlien self-assigned this Feb 25, 2022

MaximAlien added the blocked Blocked by dependency or unclarity. label Feb 25, 2022

MaximAlien force-pushed the maxim/update-dependencies branch from 773fcf3 to 11b8b7b Compare March 4, 2022 17:01

MaximAlien removed the blocked Blocked by dependency or unclarity. label Mar 4, 2022

1ec5 self-assigned this Mar 11, 2022

1ec5 reviewed Mar 11, 2022

View reviewed changes

1ec5 removed their assignment Mar 11, 2022

1ec5 force-pushed the maxim/update-dependencies branch 2 times, most recently from e4a6406 to 2bcd189 Compare March 11, 2022 22:49

1ec5 changed the title ~~Update dependencies.~~ Upgrade to MapboxMaps v10.4.0-beta.1, MapboxNavigationNative v90.0.0 Mar 11, 2022

Udumft reviewed Mar 16, 2022

View reviewed changes

MaximAlien added 4 commits March 16, 2022 13:27

Update to Mapbox Maps v10.4.0-beta.1.

28f8313

Update changelog.

057f47f

Update to Mapbox Navigation Native v90.0.0.

fc28612

Update CocoaPodsTest target to the latest dependencies.

0125e7e

bamx23 reviewed Mar 17, 2022

View reviewed changes

1ec5 reviewed Mar 17, 2022

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

removed explicit main thread forcing for set routes callbacks

53268bc

Updated changelog

312ffe3

removed parsing route in background thread

b00e325

Udumft added 2 commits March 18, 2022 16:43

limited NN log level to 'info'

b033149

Bumped Directions to 2.4.0.-beta.1

520bc89

bamx23 added 3 commits March 18, 2022 17:55

Depend on exact pre-release version of Directions

4ad728c

Disable testPuck3DLayerPosition

aaaf773

Update CHANGELOG about version of Directions

4f6c20c

Update testLatestDescriptorsAreFromGlobalNavigatorCacheHandle

b194977

1ec5 approved these changes Mar 18, 2022

View reviewed changes

bamx23 mentioned this pull request Mar 18, 2022

Update or remove testPuck3DLayerPosition #3790

Closed

bamx23 merged commit f8198e3 into main Mar 18, 2022

bamx23 deleted the maxim/update-dependencies branch March 18, 2022 18:43

		// TODO: Is it safe to set the leg index to 0 when unsetting a route?
		setRoutes(nil, 0, completion)

		func unsetRoutes(uuid: UUID, completion: @escaping (Result<RouteInfo, Error>) -> Void) {
		routeCoordinator.endActiveNavigation(with: uuid, completion: completion)


		sharedNavigator.setRoutes(routes, uuid: sessionUUID) { result in
		sharedNavigator.setRoutes(navigationRoutes, uuid: sessionUUID, legIndex: UInt32(progress.legIndex)) { result in

Upgrade to MapboxMaps v10.4.0-rc.1, MapboxNavigationNative v92.0.0. #3765

Upgrade to MapboxMaps v10.4.0-rc.1, MapboxNavigationNative v92.0.0. #3765

Conversation

MaximAlien commented Feb 25, 2022 • edited by Udumft Loading

MaximAlien commented Feb 25, 2022 • edited Loading

mapbox-github-ci-issues-public-1 bot commented Mar 4, 2022

mapbox-github-ci-issues-public-1 bot commented Mar 4, 2022

mapbox-github-ci-issues-public-1 bot commented Mar 11, 2022

mapbox-github-ci-issues-public-1 bot commented Mar 11, 2022

mapbox-github-ci-issues-public-1 bot commented Mar 11, 2022

mapbox-github-ci-issues-public-1 bot commented Mar 11, 2022

1ec5 commented Mar 11, 2022

mapbox-github-ci-issues-public-1 bot commented Mar 11, 2022

mapbox-github-ci-issues-public-1 bot commented Mar 11, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mapbox-github-ci-issues-public-1 bot commented Mar 11, 2022

mapbox-github-ci-issues-public-1 bot commented Mar 11, 2022

Choose a reason for hiding this comment

mapbox-github-ci-issues-public-1 bot commented Mar 17, 2022

mapbox-github-ci-issues-public-1 bot commented Mar 17, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Udumft Mar 17, 2022 • edited Loading

Choose a reason for hiding this comment

mapbox-github-ci-issues-public-1 bot commented Mar 17, 2022

mapbox-github-ci-issues-public-1 bot commented Mar 17, 2022

mapbox-github-ci-issues-public-1 bot commented Mar 18, 2022

mapbox-github-ci-issues-public-1 bot commented Mar 18, 2022

mapbox-github-ci-issues-public-1 bot commented Mar 18, 2022

mapbox-github-ci-issues-public-1 bot commented Mar 18, 2022

mapbox-github-ci-issues-public-1 bot commented Mar 18, 2022

Breaking Changes in MapboxCoreNavigation

Breaking API Changes

NavigationRouteOptions

NavigationMatchOptions

mapbox-github-ci-issues-public-1 bot commented Mar 18, 2022

mapbox-github-ci-issues-public-1 bot commented Mar 18, 2022

Breaking Changes in MapboxCoreNavigation

Breaking API Changes

NavigationMatchOptions

NavigationRouteOptions

mapbox-github-ci-issues-public-1 bot commented Mar 18, 2022

mapbox-github-ci-issues-public-1 bot commented Mar 18, 2022

Breaking Changes in MapboxCoreNavigation

Breaking API Changes

NavigationRouteOptions

NavigationMatchOptions

mapbox-github-ci-issues-public-1 bot commented Mar 18, 2022

Udumft commented Mar 18, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Upgrade to MapboxMaps `v10.4.0-rc.1`, MapboxNavigationNative `v92.0.0`. #3765

Upgrade to MapboxMaps `v10.4.0-rc.1`, MapboxNavigationNative `v92.0.0`. #3765

MaximAlien commented Feb 25, 2022 •

edited by Udumft

Loading

MaximAlien commented Feb 25, 2022 •

edited

Loading

Udumft Mar 17, 2022 •

edited

Loading

`NavigationRouteOptions`

`NavigationMatchOptions`

`NavigationMatchOptions`

`NavigationRouteOptions`

`NavigationRouteOptions`

`NavigationMatchOptions`