Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discontinue Objective-C compatibility #31

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Discontinue Objective-C compatibility #31

merged 1 commit into from
Oct 30, 2019

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Oct 30, 2019

With this PR, the public API no longer bridges to Objective-C. Additionally, the library relies more heavily on Codable and pure Swift enumerations.

/ref mapbox/mapbox-directions-swift#381
/cc @JThramer

@1ec5 1ec5 added the build label Oct 30, 2019
@1ec5 1ec5 requested review from frederoni and JThramer October 30, 2019 10:43
@1ec5 1ec5 self-assigned this Oct 30, 2019
@1ec5 1ec5 added this to the v1.0 milestone Oct 30, 2019
@1ec5 1ec5 mentioned this pull request Oct 30, 2019
Closed
@1ec5 1ec5 added the backwards incompatible changes that break backwards compatibility of public API label Oct 30, 2019
JThramer
JThramer approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@JThramer JThramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cat-wobble

@1ec5
Copy link
Contributor Author

1ec5 commented Oct 30, 2019

Bye-bye AppleScript.

@1ec5 1ec5 merged commit 322ea13 into master Oct 30, 2019
@1ec5 1ec5 deleted the 1ec5-obj-cya branch October 30, 2019 21:59
@1ec5 1ec5 modified the milestones: v1.0, v0.3.0 Jan 6, 2020
@1ec5 1ec5 mentioned this pull request Jan 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JThramer JThramer JThramer approved these changes

@frederoni frederoni Awaiting requested review from frederoni

Assignees

@1ec5 1ec5

Labels
backwards incompatible changes that break backwards compatibility of public API build
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@1ec5 @JThramer