Round-trip GeoJSON foreign members #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any concrete GeoJSON object type can now store and round-trip foreign members back to JSON.
macdrevx
reviewed
Dec 14, 2021
macdrevx
reviewed
Dec 14, 2021
macdrevx
reviewed
Dec 14, 2021
macdrevx
approved these changes
Dec 14, 2021
bamx23
approved these changes
Dec 15, 2021
1ec5
force-pushed
the
1ec5-foreign-members-174
branch
from
69b7e3f to
8659740
Compare
This was referenced Dec 20, 2021
nighthawk
added a commit
to maparoni/GeoJSONKit
that referenced
this pull request
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any concrete GeoJSON object type can now store and round-trip foreign members back to JSON. For example, we now preserve properties such as
crs(common in ArcGIS output) andwhen(part of the GeoJSON-T extension). However, foreign members aren’t interpreted in any way, so if a nonstandard CRS is provided, this library’s various spatial functions will probably misinterpret the coordinates. This behavior is consistent with the GeoJSON specification, RFC 7946.Fixes #174.
/cc @Udumft @macdrevx @SiarheiFedartsou