[🚧 WIP]: linking iOS #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrousavy
reviewed
Feb 22, 2024
| @@ -20,7 +20,9 @@ target="release" | |||
| echo "Building Filament for iOS ($target)..." | |||
| # -s = iOS simulator support | |||
| # -l = Build fat universal library (x86_64 + arm64) | |||
| ./build.sh -s -p ios -i "$target" | |||
| # -c = Cleans out the cmake build directory | |||
There was a problem hiding this comment.
for debugging fine, but please revert before merging as this does a clean build everytime instead of doing it incrementally
This reverts commit 8f2cf3e.
mrousavy
force-pushed
the
fix/ios-linking-filament
branch
from
ec512c1 to
c26d56d
Compare
This reverts commit 969dee7.
…/react-native-filament into fix/ios-linking-filament
…/react-native-filament into fix/ios-linking-filament
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.