Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix error message display when no translation is available #1036

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Fix error message display when no translation is available #1036

wants to merge 1 commit into from

Conversation

jpetitcolas
Copy link
Contributor

Fixes on:

  • Creation
  • Edit
  • Delete
  • Batch delete
  • List
  • Show

@orgito
Copy link

orgito commented May 5, 2016

What is the purpose of that line?

const errorMessage = this.config.getErrorMessageFor(this.view, error) || 'ERROR_MESSAGE';

In what situation will getErrorMessageFor return a translationId?

@josephwmorse josephwmorse mentioned this pull request May 6, 2016
Open
@Phocea Phocea mentioned this pull request Jun 8, 2016
Closed
@fedotxxl
Copy link
Contributor

fedotxxl commented Jun 8, 2016

when are you going to close it? Isn't it urgent?

@Phocea Phocea mentioned this pull request Jun 17, 2016
Closed
@RichardBradley
Copy link
Contributor

My PR #1130 might fix some or all of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpetitcolas @orgito @fedotxxl @RichardBradley