fixing issue #808 #1067
Open
fixing issue #808 #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fzaninotto Please check the error (https://travis-ci.org/marmelab/ng-admin/builds/130531626#L879) |
| @@ -1,5 +1,6 @@ | |||
| node_modules | |||
| dist | |||
| .idea | |||
There was a problem hiding this comment.
please include this in your user gitignore, this has nothing to do in a project gitignore
|
These changes may have some drawbacks. Indeed, some API may expect all the entity fields in the request payload, even the non-editable ones. Yet, as far as I understand your PR, you do not send non editable fields anymore. That's a big BC break, and I am not sure we handle it properly. A better way would be to retrieve the original entry values and to set them back to the API. Let's postpone it to another version than the 1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #808