Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create intermediate folders for cache_dir #137

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

Simon-Reif
Copy link
Contributor

got a file not found error before any jobs started
fixed it by replacing "os.mkdir(cache_dir)" with "os.makedirs(cache_dir)" in line 290 in cluster_utils/server/utils.py

@luator luator self-requested a review November 28, 2024 14:47
Copy link
Member

@luator luator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

I have just one small change request: Please add an entry in the CHANGELOG.md file (in the "Unreleased" section), something like this:

### Fixed
- Fixed error if parent(s) of the cache directory do not exist.

@luator luator enabled auto-merge November 28, 2024 15:09
Copy link
Member

@luator luator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@luator luator merged commit 1bae454 into martius-lab:master Nov 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants