-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update LOBSTER output files list #1044
Draft
naik-aakash
wants to merge
6
commits into
materialsproject:main
Choose a base branch
from
naik-aakash:update_lobster_outputs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] Update LOBSTER output files list #1044
naik-aakash
wants to merge
6
commits into
materialsproject:main
from
naik-aakash:update_lobster_outputs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naik-aakash
changed the title
[WIP] Update output files list
[WIP] Update LOBSTER output files list
Nov 5, 2024
13 tasks
naik-aakash
commented
Nov 17, 2024
naik-aakash
commented
Nov 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1044 +/- ##
==========================================
+ Coverage 72.82% 76.93% +4.11%
==========================================
Files 187 187
Lines 13637 13627 -10
Branches 1370 1372 +2
==========================================
+ Hits 9931 10484 +553
+ Misses 3161 2592 -569
- Partials 545 551 +6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With LOBSTER v>=5, There are new keywords added that enables generating new output files for specific types of analysis, ideally they should also get gzipped if user enables such calculations, thus this list of output has been updated
Todo