Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update LOBSTER output files list #1044

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

naik-aakash
Copy link
Contributor

@naik-aakash naik-aakash commented Nov 5, 2024

Changes

With LOBSTER v>=5, There are new keywords added that enables generating new output files for specific types of analysis, ideally they should also get gzipped if user enables such calculations, thus this list of output has been updated

Todo

  • Add test files and update tests

@naik-aakash naik-aakash changed the title update output files list [WIP] Update output files list Nov 5, 2024
@naik-aakash naik-aakash marked this pull request as draft November 5, 2024 16:42
@naik-aakash naik-aakash changed the title [WIP] Update output files list [WIP] Update LOBSTER output files list Nov 5, 2024
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.93%. Comparing base (4244da9) to head (47f486d).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1044      +/-   ##
==========================================
+ Coverage   72.82%   76.93%   +4.11%     
==========================================
  Files         187      187              
  Lines       13637    13627      -10     
  Branches     1370     1372       +2     
==========================================
+ Hits         9931    10484     +553     
+ Misses       3161     2592     -569     
- Partials      545      551       +6     
Files with missing lines Coverage Δ
src/atomate2/lobster/files.py 91.66% <ø> (ø)

... and 44 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant