Add support for Pydantic 2 #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew-S-Rosen
changed the title
Andrew-S-Rosen
changed the title
Andrew-S-Rosen
commented
Sep 28, 2023
| @@ -161,7 +161,7 @@ class InnerSchema(BaseModel): | |||
| class MediumSchema(BaseModel): | |||
| s: str | |||
| nested: InnerSchema | |||
| nested_opt: Optional[InnerSchema] | |||
There was a problem hiding this comment.
Note: I had to change this in the test suite. For some reason, leaving it as Optional[InnerSchema] caused ref.nested.nested_opt.m.uuid not to be raised. Must be a change in how Pydantic 2 handles optional-annotated fields.
|
@utf: This should be ready to review + merge! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #440 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 1509 1510 +1
Branches 412 414 +2
=========================================
+ Hits 1509 1510 +1
|
|
Thanks @Andrew-S-Rosen, looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@utf: As you likely saw, Pydantic 2 introduced many new features and changes. In an effort to support Pydantic 2, much of the MP software stack has now been modified accordingly. With maggma, emmet, and monty now supporting Pydantic 2, I have updated Jobflow to match.
Tagging @munrojm who initiated this switch for the rest of the MP stack. I haven't gotten all the tests to pass yet --- suggestions are very welcome!
Closes #422.