Fix handling of function from standard library #516
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I was trying to use a function from the standard library to create a simple example and I got an error:
gives
The reason is that
sleep
has a__self__
attribute and inJob
it is then converted to a bound method. This seems to be shared by most (all?) the functions in the standard library.To adress this I changed the check performed in
Job.run()
assuming that if the__self__
is a module, than the callable should not be converted to a method. I am not entirely sure if I may be missing some case where this is not true.