Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobflowSettings add LOG_FORMAT, also directly passable to run_locally #706

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

janosh
Copy link
Member

@janosh janosh commented Nov 16, 2024

No description provided.

@janosh janosh added enhancement New feature or request ux User experience labels Nov 16, 2024
@janosh janosh requested a review from utf November 16, 2024 18:58
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.23%. Comparing base (46e3b89) to head (ddb53dd).
Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #706   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files          21       21           
  Lines        1573     1578    +5     
  Branches      427      335   -92     
=======================================
+ Hits         1561     1566    +5     
  Misses         10       10           
  Partials        2        2           
Files with missing lines Coverage Δ
src/jobflow/managers/local.py 100.00% <100.00%> (ø)
src/jobflow/settings.py 100.00% <100.00%> (ø)
src/jobflow/utils/log.py 100.00% <100.00%> (ø)
---- 🚨 Try these New Features:

@utf
Copy link
Member

utf commented Nov 18, 2024

Thanks @janosh. Looks great to me.

@utf utf merged commit cef3584 into main Nov 18, 2024
9 checks passed
@janosh janosh deleted the custom-log-fmt branch November 18, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ux User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants