-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix monty
imports, enhance test for Outcar
parser to cover uncompressed format
#4068
Draft
DanielYang59
wants to merge
25
commits into
materialsproject:master
Choose a base branch
from
DanielYang59:test-monty-reverse-read
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fix monty
imports, enhance test for Outcar
parser to cover uncompressed format
#4068
DanielYang59
wants to merge
25
commits into
materialsproject:master
from
DanielYang59:test-monty-reverse-read
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
DanielYang59
force-pushed
the
test-monty-reverse-read
branch
from
September 15, 2024 05:35
c234535
to
7d2ed7b
Compare
DanielYang59
changed the title
Test
Test Oct 10, 2024
monty
fix for reverse readlinemonty
fix for reverse_readline
DanielYang59
commented
Nov 8, 2024
DanielYang59
changed the title
Test
Fix Dec 11, 2024
monty
fix for reverse_readline
monty
imports, enhance test for Outcar
parser to cover uncompressed format
DanielYang59
force-pushed
the
test-monty-reverse-read
branch
from
December 20, 2024 10:27
6b44797
to
d41a039
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
monty
fix for reverse readline, to close Outcar class returns empty magnetization attribute when parsing OUTCAR file on Windows operating system #4033reverse_readline
with fasterreverse_readfile
monty
importspymatgen/tests/io/vasp/test_outputs.py
Lines 802 to 823 in 60464fd