feat(client) removed GZ short code for FireFox family and Create test…

… check shortcode comparison to browser
matomo-org · Nov 18, 2024 · 4b49df6 · 4b49df6
1 parent ab44b2c
commit 4b49df6
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/Parser/Client/Browser.php b/Parser/Client/Browser.php
@@ -774,11 +774,11 @@ class Browser extends AbstractClientParser
         ],
         'Firefox'            => [
             'FF', 'BI', 'BF', 'BH', 'BN', 'C0', 'CU', 'EI', 'F1',
-            'FB', 'FE', 'AX', 'FM', 'FR', 'FY', 'GZ', 'I4', 'IF',
+            'FB', 'FE', 'AX', 'FM', 'FR', 'FY', 'I4', 'IF', '8P',
             'IW', 'LH', 'LY', 'MB', 'MN', 'MO', 'MY', 'OA', 'OS',
             'PI', 'PX', 'QA', 'S5', 'SX', 'TF', 'TO', 'WF', 'ZV',
             'FP', 'AD', '2I', 'P9', 'KJ', 'WY', 'VK', 'W5',
-            '7C', 'N7', 'W7', '8P',
+            '7C', 'N7', 'W7',
         ],
         'Internet Explorer'  => ['IE', 'CZ', 'BZ', 'IM', 'PS', '3A', '4A', 'RN'],
         'Konqueror'          => ['KO'],

diff --git a/Tests/Parser/Client/BrowserTest.php b/Tests/Parser/Client/BrowserTest.php
@@ -105,6 +105,26 @@ public function testBrowserFamiliesNoDuplicates(): void
         }
     }
 
+    public function testShortCodesComparisonWithBrowsers(): void
+    {
+        $reflectionClass   = new \ReflectionClass(Browser::class);
+        $availableBrowsers = $reflectionClass->getProperty('availableBrowsers')->getValue();
+        $browserFamilies   = $reflectionClass->getProperty('browserFamilies')->getValue();
+        $result            = [];
+
+        foreach ($browserFamilies as $codes) {
+            foreach ($codes as $code) {
+                if (isset($availableBrowsers[$code])) {
+                    continue;
+                }
+
+                $result[] = $code;
+            }
+        }
+
+        $this->assertEquals([], $result, 'These shortcode does not match the list of browsers');
+    }
+
     /**
      * @return array
      */