Fix CI misuse of --ignore-platform-reqs

matomo-org · Dec 22, 2024 · fa38ec4 · fa38ec4
1 parent d72ba35
commit fa38ec4
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/.github/workflows/phpcs.yml b/.github/workflows/phpcs.yml
@@ -24,7 +24,7 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - name: Install dependencies
-        run: composer install --dev --prefer-dist --no-progress --no-suggest --ignore-platform-reqs
+        run: composer install --dev --prefer-dist --no-progress --no-suggest
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:

diff --git a/.github/workflows/phpunit.yml b/.github/workflows/phpunit.yml
@@ -24,20 +24,30 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
-        php-version: ['7.2', '8.4']
+        php-version: ['7.2']
+        composer-options: ['']
         include:
           - php-version: 7.3
             os: ubuntu-latest
+            composer-options: ''
           - php-version: 7.4
             os: ubuntu-latest
+            composer-options: ''
           - php-version: 8.0
             os: ubuntu-latest
+            composer-options: ''
           - php-version: 8.1
             os: ubuntu-latest
+            composer-options: ''
           - php-version: 8.2
             os: ubuntu-latest
+            composer-options: ''
           - php-version: 8.3
             os: ubuntu-latest
+            composer-options: ''
+          - php-version: 8.4
+            os: ubuntu-latest
+            composer-options: '--ignore-platform-reqs'
     steps:
       - uses: actions/checkout@v4
       - name: Install PHP
@@ -48,8 +58,8 @@ jobs:
           extensions: memcached
       - name: "Composer install"
         run: |
-          composer install --ignore-platform-reqs
-          composer require doctrine/cache ~1.2 --ignore-platform-reqs
+          composer install ${{ matrix.composer-options }}
+          composer require doctrine/cache ~1.2 ${{ matrix.composer-options }}
       - name: PHPUnit / PHP ${{ matrix.php-version }}
         run: |
           php -v