Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-744] Add --include-only-org-members flag #7244

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[GH-744] Add --include-only-org-members flag #7244

wants to merge 6 commits into from

Conversation

burakcakirel
Copy link

Summary

Add --include-only-org-members flag doc

Ticket Link

Fixes mattermost/mattermost-plugin-github#744

@burakcakirel
Update github-interoperability.rst
5489e53 
Add `--include-only-org-members` flag doc
@mattermost-build
Copy link
Contributor

Hello @burakcakirel,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@burakcakirel burakcakirel changed the title Update github-interoperability.rst [GH-744] Add --include-only-org-members flag Jul 3, 2024
@cwarnermm cwarnermm requested review from mickmister and cwarnermm July 3, 2024 17:22
@cwarnermm cwarnermm added 1: Dev Review Requires review by a core commiter 2: Editor Review Requires review by an editor labels Jul 3, 2024
@mickmister mickmister added the Do Not Merge Should not be merged until this label is removed label Jul 4, 2024
@mickmister
Copy link
Contributor

This PR should be merged after mattermost/mattermost-plugin-github#797 is merged and released

cwarnermm
cwarnermm approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @burakcakirel!

@cwarnermm
Copy link
Member

@mickmister - I see you added the Do not merge label. What conditions need to be met so that this PR can be merged? Is this docs change linked to a specific release?

@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request and removed 1: Dev Review Requires review by a core commiter 2: Editor Review Requires review by an editor labels Jul 4, 2024
@mickmister
Copy link
Contributor

@cwarnermm This PR should be merged after mattermost/mattermost-plugin-github#797 is merged and released

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@cwarnermm cwarnermm removed Do Not Merge Should not be merged until this label is removed Lifecycle/1:stale labels Aug 16, 2024
@cwarnermm cwarnermm added the Do Not Merge/Awaiting Next Release To be merged with the next release (e.g. API documentation updates) label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwarnermm cwarnermm cwarnermm approved these changes

@mickmister mickmister mickmister approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request Contributor Do Not Merge/Awaiting Next Release To be merged with the next release (e.g. API documentation updates)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support --include-only-org-members for channel subscriptions
4 participants
@burakcakirel @mattermost-build @mickmister @cwarnermm