[MM-61912] Download and install latest Dashboard v2 automatically #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metrics: install dashboard v2 (fix var)
agnivade
reviewed
Dec 13, 2024
|
|
||
| // Removes the DS_PROMETHEUS variable requirement to allow grafana to use the only prometheus | ||
| // datasource available in the load-test envionment. | ||
| re := regexp.MustCompile(`,\r?\n\s+\"uid\":\s?\"\$\{DS_PROMETHEUS\}\"`) |
There was a problem hiding this comment.
Hmm .. I am not a big fan of this. Can we not use the t.UploadDashboard method to upload the dashboard, instead of manually copying over the json file to a folder?
There was a problem hiding this comment.
Oh yeah, I recall thinking about checking that method when I moved this upstream but I forget, sorry, let me make the changes.
agarciamontoro
approved these changes
Dec 13, 2024
deployment/terraform/metrics.go
Outdated
| @@ -352,6 +353,29 @@ func (t *Terraform) setupMetrics(extAgent *ssh.ExtAgent) error { | |||
| return fmt.Errorf("error while uploading dashboard_json: output: %s, error: %w", out, err) | |||
| } | |||
|
|
|||
| // Download dashboard v2 from and upload it | |||
There was a problem hiding this comment.
There's something missing here. From grafana.com, you meant?
agnivade
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Downloads the latest Dashboard v2 revision from the Grafana gallery and installs it into the environment automatically. It naively removes the DS_PROMETHEUS variable from the JSON dashboard code so it automatically uses the primary prometheus source present in the deployment.
Ticket Link
https://mattermost.atlassian.net/browse/MM-61912