MM 45015 - auto follow threads #7463

tanmaythole · 2023-07-21T16:41:03Z

Summary

Added auto follow thread select option

Ticket Link

Fixes mattermost/mattermost#22386
https://mattermost.atlassian.net/browse/MM-45015

Checklist

Added or updated unit tests (required for all new features)
Has UI changes
Includes text changes and localization file updates
Have tested against the 5 core themes to ensure consistency between them.

Device Information

This PR was tested on: Samsung M11 - 12 version

Screenshots

Release Note

Added a new select option to auto-follow all threads in the Channel's Info.

…MM-45015/auto-follow

mattermost-build · 2023-07-21T16:41:06Z

Hello @tanmaythole,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

app/screens/channel_info/options/index.tsx

app/screens/channel_info/options/auto_follow_threads/auto_follow_threads.tsx

mattermost-build · 2023-08-06T01:01:57Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

larkox · 2023-08-07T07:44:25Z

@tanmaythole Are you still working on this? Could you address the comments?

tanmaythole · 2023-08-07T11:50:34Z

@tanmaythole Are you still working on this? Could you address the comments?

Yes, give me some time. I will commit changes as soon as possible.

enahum · 2023-08-15T17:03:08Z

app/screens/channel_info/options/index.tsx

 }: Props) => {
    const isDMorGM = isTypeDMorGM(type);

    return (
        <>
-            {type !== General.DM_CHANNEL &&
+            {isCRTEnabled && (
+                <AutoFollowThreads channelId={channelId}/>


does this also apply to DM's ?

enahum · 2023-08-15T17:03:58Z

app/screens/channel_info/options/auto_follow_threads/auto_follow_threads.tsx

+
+    const toggleFollow = preventDoubleTap(() => {
+        const props: Partial<ChannelNotifyProps> = {
+            channel_auto_follow_threads: followedStatus ? 'off' : 'on',


you should be using the constants declared in the constants/channel file

enahum · 2023-08-15T17:05:29Z

app/screens/channel_info/options/auto_follow_threads/auto_follow_threads.tsx

+            channel_auto_follow_threads: followedStatus ? 'off' : 'on',
+        };
+        setAutoFollow(!autoFollow);
+        updateChannelNotifyProps(serverUrl, channelId, props);


what happens if this fails? I know is the same with other options, just want to see what would be the consequence and if we should also thing about this for the other options as well.

Okay need to add checks for this and other option as well

enahum

I think you need to run i18n-extract as is missing the en.json file

larkox

No extra comments from my side.

mattermost-build · 2023-09-03T01:02:16Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

mattermost-build · 2023-09-26T16:35:51Z

Building app in separate branch.

mattermost-build · 2023-10-09T05:42:23Z

Building app in separate branch.

lindy65 · 2023-10-09T06:58:14Z

/update-branch

lindy65

Thanks @tanmaythole

I'm going to qa-defer this PR as I'm having trouble accessing master.test.mattermost.com from mobile. I will test post merge.

cc// @johndavidlugtu @enahum

hanzei · 2023-11-14T08:57:56Z

@larkox @enahum Can we merge this PR?

* auto follow select option added * unused code removed * auto follow threads condition fixed on CRT enabled * error handles --------- Co-authored-by: Mattermost Build <[email protected]>

tanmaythole added 3 commits July 18, 2023 22:32

auto follow select option added

a4417dd

Merge branch 'main' of github.com:tanmaythole/mattermost-mobile into …

d71b440

…MM-45015/auto-follow

unused code removed

a870b65

mm-cloud-bot added the release-note label Jul 21, 2023

mattermost-build added the Contributor label Jul 21, 2023

tanmaythole changed the title ~~Mm 45015/auto follow~~ MM 45015 - auto follow threads Jul 21, 2023

larkox requested review from larkox and enahum July 26, 2023 12:48

enahum requested changes Jul 26, 2023

View reviewed changes

app/screens/channel_info/options/index.tsx Outdated Show resolved Hide resolved

app/screens/channel_info/options/auto_follow_threads/auto_follow_threads.tsx Outdated Show resolved Hide resolved

mattermost-build added the Lifecycle/1:stale label Aug 6, 2023

auto follow threads condition fixed on CRT enabled

bb8fb35

tanmaythole requested a review from enahum August 15, 2023 16:45

enahum approved these changes Aug 15, 2023

View reviewed changes

enahum requested changes Aug 15, 2023

View reviewed changes

larkox added 2: Dev Review Requires review by a core commiter and removed Lifecycle/1:stale labels Aug 16, 2023

larkox approved these changes Aug 16, 2023

View reviewed changes

mattermost-build added the Lifecycle/1:stale label Sep 3, 2023

cwarnermm added the Docs/Needed Requires documentation label Sep 6, 2023

error handles

3bf2a2c

tanmaythole requested a review from enahum September 18, 2023 11:17

enahum approved these changes Sep 26, 2023

View reviewed changes

enahum removed the 2: Dev Review Requires review by a core commiter label Sep 26, 2023

enahum requested a review from lindy65 September 26, 2023 08:00

enahum added the 3: QA Review Requires review by a QA tester label Sep 26, 2023

lindy65 added the Build Apps for PR Build the mobile app for iOS and Android to test label Sep 26, 2023

mattermost-build removed the Build Apps for PR Build the mobile app for iOS and Android to test label Sep 26, 2023

Merge branch 'main' into MM-45015/auto-follow

59d4d4d

lindy65 added the Build Apps for PR Build the mobile app for iOS and Android to test label Oct 9, 2023

mattermost-build removed the Build Apps for PR Build the mobile app for iOS and Android to test label Oct 9, 2023

Merge branch 'main' into MM-45015/auto-follow

65ce9d7

lindy65 approved these changes Oct 9, 2023

View reviewed changes

lindy65 added QA Deferred Agreement with QA that these changes will be tested post-merge 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Oct 9, 2023

larkox merged commit 805c794 into mattermost:main Nov 14, 2023
1 check passed

hanzei removed the Lifecycle/1:stale label Nov 14, 2023

amyblais added this to the v2.12.0 milestone Nov 14, 2023

tanmaythole deleted the MM-45015/auto-follow branch November 23, 2023 12:03

cwarnermm added Docs/Done Required documentation has been written and removed Docs/Needed Requires documentation labels Dec 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MM 45015 - auto follow threads #7463

MM 45015 - auto follow threads #7463

tanmaythole commented Jul 21, 2023 •

edited

Loading

mattermost-build commented Jul 21, 2023

mattermost-build commented Aug 6, 2023

larkox commented Aug 7, 2023

tanmaythole commented Aug 7, 2023

enahum Aug 15, 2023

enahum Aug 15, 2023

enahum Aug 15, 2023

tanmaythole Aug 23, 2023

enahum left a comment

larkox left a comment

mattermost-build commented Sep 3, 2023

mattermost-build commented Sep 26, 2023

mattermost-build commented Oct 9, 2023

lindy65 commented Oct 9, 2023

lindy65 left a comment •

edited

Loading

hanzei commented Nov 14, 2023

MM 45015 - auto follow threads #7463

MM 45015 - auto follow threads #7463

Conversation

tanmaythole commented Jul 21, 2023 • edited Loading

Summary

Ticket Link

Checklist

Device Information

Screenshots

Release Note

mattermost-build commented Jul 21, 2023

mattermost-build commented Aug 6, 2023

larkox commented Aug 7, 2023

tanmaythole commented Aug 7, 2023

enahum Aug 15, 2023

Choose a reason for hiding this comment

enahum Aug 15, 2023

Choose a reason for hiding this comment

enahum Aug 15, 2023

Choose a reason for hiding this comment

tanmaythole Aug 23, 2023

Choose a reason for hiding this comment

enahum left a comment

Choose a reason for hiding this comment

larkox left a comment

Choose a reason for hiding this comment

mattermost-build commented Sep 3, 2023

mattermost-build commented Sep 26, 2023

mattermost-build commented Oct 9, 2023

lindy65 commented Oct 9, 2023

lindy65 left a comment • edited Loading

Choose a reason for hiding this comment

hanzei commented Nov 14, 2023

tanmaythole commented Jul 21, 2023 •

edited

Loading

lindy65 left a comment •

edited

Loading