MM-54558 SSO code challenge verification #7587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enahum
added
2: Dev Review
larkox
approved these changes
Oct 6, 2023
jupenur
requested changes
Oct 10, 2023
app/utils/strings.ts
Outdated
| const chars = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789'; | ||
| const charsLenght = chars.length; | ||
| while (counter < length) { | ||
| result += chars.charAt(Math.floor(Math.random() * charsLenght)); |
There was a problem hiding this comment.
This needs to use a CSPRNG. Math.random is notoriously predictable.
There was a problem hiding this comment.
Can you double check this lib? https://www.npmjs.com/package/react-native-securerandom
|
Closing as won't accept |
mattermost-build
removed
the
Do Not Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds code challenge verification for SSO logins using the web browser.
Applies to OAuth, OpenID and SAML
Ticket Link
https://mattermost.atlassian.net/browse/MM-54558
Server PR: mattermost/mattermost#24734
Release Note