Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goodbye, GraphQL #7597

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Goodbye, GraphQL #7597

merged 1 commit into from
Oct 16, 2023

Conversation

larkox
Copy link
Contributor

@larkox larkox commented Oct 10, 2023

Summary

Remove all graphQL related code from the mobile app

Ticket Link

None

Release Note

Removed support for GraphQL Feature Flag

@larkox larkox requested review from hmhealey and enahum October 10, 2023 14:45
@larkox
Copy link
Contributor Author

larkox commented Oct 10, 2023

cc @agnivade @M-ZubairAhmed @saturninoabril

@larkox larkox added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Oct 11, 2023
@hmhealey hmhealey removed the 2: Dev Review Requires review by a core commiter label Oct 11, 2023
@yasserfaraazkhan yasserfaraazkhan added the Build Apps for PR Build the mobile app for iOS and Android to test label Oct 12, 2023
@mattermost-build mattermost-build removed the Build Apps for PR Build the mobile app for iOS and Android to test label Oct 12, 2023
@mattermost-build
Copy link
Contributor

Building app in separate branch.

yasserfaraazkhan
yasserfaraazkhan approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested this by posting messages, attachment, creating group, permalink, threads, leaving/joining/archiving channel, browse channel, invite to team.

@larkox larkox added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Oct 16, 2023
@larkox larkox merged commit a3eeb69 into mattermost:main Oct 16, 2023
4 checks passed
@amyblais amyblais modified the milestones: v2.11.0, v2.10.0 Oct 16, 2023
fewva pushed a commit to fewva/mattermost-mobile that referenced this pull request Jan 12, 2024
@larkox
Goodbye, GraphQL (mattermost#7597)
237f6a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasserfaraazkhan yasserfaraazkhan yasserfaraazkhan approved these changes

@enahum enahum enahum approved these changes

@hmhealey hmhealey hmhealey approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request kind/refactor release-note
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.
8 participants
@larkox @mattermost-build @hmhealey @enahum @yasserfaraazkhan @jwilander @amyblais @mm-cloud-bot