[MM-54599] Fix Servers bottom sheet #7609
Conversation
…t's < 60% of the screen
…:Paul-vrn/mattermost-mobile into MM-54599_fix-servers-bottom-sheet-height
|
|
||
| import {BUTTON_HEIGHT} from '@app/screens/bottom_sheet'; |
There was a problem hiding this comment.
| import {BUTTON_HEIGHT} from '@app/screens/bottom_sheet'; | |
| import {BUTTON_HEIGHT} from '@screens/bottom_sheet'; |
And sort the import
| import {useSafeAreaInsets} from 'react-native-safe-area-context'; | ||
|
|
||
| import {BUTTON_HEIGHT, TITLE_HEIGHT} from '@app/screens/bottom_sheet'; |
There was a problem hiding this comment.
Remove
| import {BUTTON_HEIGHT, TITLE_HEIGHT} from '@app/screens/bottom_sheet'; |
| import ServerIcon from '@components/server_icon'; | ||
| import {useServerUrl} from '@context/server'; | ||
| import {useTheme} from '@context/theme'; | ||
| import {subscribeAllServers} from '@database/subscription/servers'; | ||
| import {subscribeUnreadAndMentionsByServer, type UnreadObserverArgs} from '@database/subscription/unreads'; | ||
| import {useIsTablet} from '@hooks/device'; | ||
| import {BUTTON_HEIGHT, TITLE_HEIGHT} from '@screens/bottom_sheet'; |
| const maxSnapPoint = Math.min( | ||
| maxScreenHeight, | ||
| bottomSheetSnapPoint(registeredServers.current.length, 75, bottom) + TITLE_HEIGHT + BUTTON_HEIGHT + | ||
| (registeredServers.current.filter((s: ServersModel) => s.lastActiveAt).length * 42), |
There was a problem hiding this comment.
Add the 42 to a constant name, same as the 75 to clearly identify what it means
…n servers/index.tsx
…:Paul-vrn/mattermost-mobile into MM-54599_fix-servers-bottom-sheet-height
enahum
added
2: Dev Review
lindalumitchell
added
the
Build Apps for PR
|
Building app in separate branch. |
mattermost-build
removed
the
Build Apps for PR
There was a problem hiding this comment.
Verified on the PR builds on Android and iOS that after adding enough servers to cause the list to scroll, I can open the bottom sheet to view the servers, pull it up to expand the list taller, and scroll through the server list without issue. Also double-checked that functions from that list such as editing server name, removing server, and logging out of a server work as expected with no issues. 👍
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
enahum
added
4: Reviews Complete
Summary
Modified
BottomSheetFlatListstyle inapp/screens/home/channel_list/servers/server_list/index.tsxto add a bottom margin and prevent the "+Add server" bottom sheet from covering a server item.Modified
onPressfunction fromapp/screens/home/channel_list/servers/index.tsxto pre-calculate the "Your servers" Bottom sheet's height depending on the number of server items (and pushAlertText if present) up to a height of 60% of the screen. Above 60%, the sheet can be extended up to 80% of the screen.Ticket Link
Fixes mattermost/mattermost#24668
Jira MM-54599
Checklist
Device Information
This PR was tested on: Iphone 15, iOS 17.0 (using Simulator 15.0 on Mac)
Screenshots
multiple_servers.mov
Release Note