Fix interactive dialog number handling #8431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larkox
added
2: Dev Review
enahum
approved these changes
Dec 19, 2024
enahum
added
the
CherryPick/Approved
DHaussermann
added
the
Build Apps for PR
|
I have done a round of testing on this for the iOS build.
Tested only on iOS for now. There is an external service failing preventing Android builds at the moment. |
DHaussermann
approved these changes
Dec 19, 2024
DHaussermann
added
QA Review Done
and removed
3: QA Review
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
that referenced
this pull request
Dec 19, 2024
(cherry picked from commit 32453b3)
mattermost-build
added
CherryPick/Done
|
/cherry-pick release-2.24 |
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
that referenced
this pull request
Dec 19, 2024
(cherry picked from commit 32453b3)
larkox
added a commit
that referenced
this pull request
Dec 19, 2024
(cherry picked from commit 32453b3) Co-authored-by: Daniel Espino García <[email protected]>
larkox
added a commit
that referenced
this pull request
Dec 19, 2024
(cherry picked from commit 32453b3) Co-authored-by: Daniel Espino García <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The handling of the number field was not done right for a long time. We were passing a number value to the text input
valueproperty, which was completely ignoring it (since it was not a string).The changes we did to be more coherent with the types surfaced the issue, by showing
NaNin the input when we removed completely the number.This PR solves that, and makes sure we only send on the submission proper numbers, and not the empty string for number values.
Ticket Link
Fix https://mattermost.atlassian.net/browse/MM-62334
Release Note