Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding better access controls. #247

Merged
merged 8 commits into from
Dec 12, 2024
Merged

Adding better access controls. #247

merged 8 commits into from
Dec 12, 2024

Conversation

crspeller
Copy link
Member

@crspeller crspeller commented Oct 3, 2024

Adds access controls for LLM Bots.

More details in the specification here: https://mattermost.atlassian.net/wiki/spaces/FF/pages/2917400646/UX+Spec+Access+Controls
Some elements of the spec have been differed from this PR.

@crspeller crspeller marked this pull request as ready for review November 3, 2024 20:43
@crspeller crspeller requested a review from jespino December 2, 2024 15:05
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

grid-align-items: center;
`;

const MainContainer = styled.div`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so I understand, what is the purpose of calling this out as opposed to just using a div in the return statement?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit vestigial, there used to be styles there.

@crspeller crspeller merged commit 654e1e7 into master Dec 12, 2024
5 checks passed
@crspeller crspeller deleted the more-restrictions branch December 12, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants