Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-61120] Add diagnostics data to the Support Packet #532

Merged
merged 8 commits into from
Dec 10, 2024

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Nov 11, 2024

Summary

When a Support Packet gets generated, the plugin now includes diagnostics data via a diagnostics.yaml file into the Packet.

Example content of com.github.manland.mattermost-plugin-gitlab/diagnostics.yaml:

version: 1.9.1+772eab6
connected_user_count: 0
is_oauth_configured: false

Requires mattermost/mattermost#28833 on the server side

Ticket Link

https://mattermost.atlassian.net/browse/MM-61120

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Nov 11, 2024
@hanzei hanzei force-pushed the MM-61120_support-packet branch from 772eab6 to 7537319 Compare November 11, 2024 12:54
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Bump the golangci version to 1.55.0 to fix the CI issue.

See https://github.com/mattermost/mattermost-plugin-jira/pull/1136/files

@hanzei
Copy link
Collaborator Author

hanzei commented Nov 13, 2024

@wiggin77 @Kshitij-Katiyar The CI error seems unrelated. Is that a known issue?

@hanzei hanzei changed the title Add diagnostics data to the Support Packet [MM-61120] Add diagnostics data to the Support Packet Nov 14, 2024
@hanzei
Copy link
Collaborator Author

hanzei commented Nov 20, 2024

@Kshitij-Katiyar Gentle reminder to review the PR

@hanzei hanzei added this to the v1.10.0 milestone Nov 20, 2024
@hanzei
Copy link
Collaborator Author

hanzei commented Nov 20, 2024

@AayushChaudhary0001 Can you please give the PR a review?

@hanzei
Copy link
Collaborator Author

hanzei commented Nov 29, 2024

@Kshitij-Katiyar @AayushChaudhary0001 Can you please review the PR ASAP so we can get it into v1.10.0? Thanks!

@raghavaggarwal2308
Copy link
Contributor

@hanzei Sure, we will look into it

@arush-vashishtha
Copy link

Hey @hanzei , Can you please specify the testing steps for this PR so we can estimate and start working on the testing areas?

@hanzei
Copy link
Collaborator Author

hanzei commented Dec 2, 2024

@arush-vashishtha, I've updated the JIRA ticket with QA test steps. Please check out https://mattermost.atlassian.net/browse/MM-61120.

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Dec 4, 2024
@hanzei hanzei removed the request for review from Kshitij-Katiyar December 4, 2024 11:14
@hanzei
Copy link
Collaborator Author

hanzei commented Dec 10, 2024

Per discussion with @raghavaggarwal2308, QA testing will happen post-merge.

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Dec 10, 2024
@hanzei hanzei merged commit 105215e into master Dec 10, 2024
7 checks passed
@hanzei hanzei deleted the MM-61120_support-packet branch December 10, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants