vector macro patterns #272
Conversation
| @@ -131,11 +131,7 @@ pub trait Folder { | |||
| } | |||
|
|
|||
| #[inline] | |||
| fn visit_vector(&mut self, mut v: Vector) -> ExprKind { | |||
| let args: Vec<_> = v.args.into_iter().map(|exp| self.visit(exp)).collect(); | |||
There was a problem hiding this comment.
I've revisited a few of the visitor traits, trying to ascertain whether it makes sense or not to descend into the vector contents (given that they're self-quoting).
I don't have a lot of confidence in the end result, given that different visitors are used at different "expansion phases", and my understanding of those is not great.
There was a problem hiding this comment.
Given that they're self quoting, I think it is correct to not descend into the vector contents
| return false; | ||
| }; | ||
|
|
||
| if !match_list_pattern(subpatterns, &l.args, l.improper) { | ||
| // FIXME: this is not quite correct. It does not handle |
There was a problem hiding this comment.
I wanted to fix this in this PR, but it's already sizeable and near overflowing my head capacity at the moment.
| @@ -1445,6 +1445,12 @@ impl<'a> RecursiveEqualityHandler<'a> { | |||
| } | |||
| continue; | |||
| } | |||
| (MutFunc(l), MutFunc(r)) => { | |||
| @@ -90,13 +90,16 @@ | |||
| [(quasiquote (#%unquote x)) x] | |||
|
|
|||
| [(quasiquote ((#%unquote-splicing x))) (append x '())] | |||
| [(quasiquote #((#%unquote-splicing x))) (list->vector (append x '()))] | |||
There was a problem hiding this comment.
This is a very blunt and inefficient approach. Not sure if the vector builtins are/could be made available.
There was a problem hiding this comment.
We probably could - I think they should be available
That being said quasi quote is some of the most mind bending stuff to work on, so I'm fine with this for now and we can come back to it at some point in the future
| @@ -1037,12 +1037,6 @@ impl<'a> Parser<'a> { | |||
| &self.source_name.clone(), | |||
| )); | |||
|
|
|||
| if matches!(current_frame.paren_mod, Some(ParenMod::Bytes)) | |||
There was a problem hiding this comment.
Bugfix: this logic was not exhaustive enough.
|
Still interested in getting this merged? |
I am, I was sidetracked by real life™️. I'll try to rebase it soon. |
No problem at all 😄 (also, no rush!) |
Adds vector patterns to macros.