🚨 [security] Update better_errors: 2.5.1 → 2.9.1 (minor) #116

depfu · 2021-09-14T00:09:00Z

🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ better_errors (2.5.1 → 2.9.1) · Repo · Changelog

Security Advisories 🚨

🚨 Older releases of better_errors open to Cross-Site Request Forgery attack

Impact

better_errors prior to 2.8.0 did not implement CSRF protection for its internal requests. It also did not enforce the correct "Content-Type" header for these requests, which allowed a cross-origin "simple request" to be made without CORS protection. These together left an application with better_errors enabled open to cross-origin attacks.

As a developer tool, better_errors documentation strongly recommends addition only to the development bundle group, so this vulnerability should only affect development environments. Please ensure that your project limits better_errors to the development group (or the non-Rails equivalent).

Patches

Starting with release 2.8.x, CSRF protection is enforced. It is recommended that you upgrade to the latest release, or minimally to "~> 2.8.3".

Workarounds

There are no known workarounds to mitigate the risk of using older releases of better_errors.

References

Chris Moberly provided an example attack that uses a now-patched vulnerability of webpack-dev-server in conjunction with Better Errors

For more information

If you have any questions or comments about this advisory, please

Add to the discussion in better_errors

Open an issue in better_errors

Release Notes

2.9.1

Fix setting editor with symbol #492

2.9.0

Mention path in text response #487

Use Github Actions for CI #489

Exception Hints #302

Hide "live shell" hint after console has been used #490

Improve editor support for virtual environments #488

Fix "live shell" hint reappearing when frame changed #491

2.8.3

Fix 'uninitialized constant BetterErrors::Middleware::VERSION' #480

Fix CSRF_TOKEN_COOKIE_NAME wrong reference to VERSION constant #481

2.8.2

Fix path of CSRF Token cookie #478

2.8.1

Show real cause of ActionView::Template::Error with Rails 6 #477

Add TruffleRuby to CI builds #473

2.8.0

Support for Rails ActionableError #465

Allow editor links to work inside an iframe or with CSP that prohibits other protocols #440

Add CSRF protection to internal requests #474

Validate internal request method names #475

2.7.1

Show location of error in ActionView template error #463

2.7.0

Fix various specs that were passing incorrectly #453 (@RobinDaugherty)

CI tests for Ruby 2.6, 2.7; Rails 6.0 #452 (@RobinDaugherty)

CI: Drop unused sudo: false directive #457 (@olleolleolle)

Add editor preset for VSCodium #456 (@jaredmoody)

Show the last-raised error, not its "cause" #459 (@RobinDaugherty)

Fix warning: FILE in eval may not return location in binding #458 (@yuuu)

Allow skipping variable inspection by class name #449 (@felixbuenemann)

2.6.0

Specify older kramdown and i18n for older ruby versions #437

Fix NoMethodError when variables cannot be retrieved from the stack frame #430

Allow passing IPAddrs to allow_ip #444

Update CI Ruby to fix Travis CI failures #450

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ coderay (indirect, 1.1.2 → 1.1.3) · Repo · Changelog

Release Notes

1.1.3

Diff: v1.1.2...v1.1.3

Tokens: Ensure Ruby 2.6 compatibility. [#233, thanks to Jun Aruga]

SQL scanner: Add numeric data type. [#223, thanks to m16a1]

Java scanner: Add var as type. [#229, thanks to Davide Angelocola]

Gem: Fix deprecation warning. [#246, thanks to David Rodríguez]

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 56 commits:

↗️ erubi (indirect, 1.9.0 → 1.10.0) · Repo · Changelog

Release Notes

1.10.0 (from changelog)

* Improve template parsing, mostly by reducing allocations (jeremyevans)


Do not ship tests in the gem, reducing gem size about 20% (jeremyevans)


Support :literal_prefix and :literal_postfix options for how to output literal tags (e.g. <%% code %>) (jaredcwhite) (#26, #27)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 22 commits:

↗️ rack (indirect, 2.1.1 → 2.2.3) · Repo · Changelog

Security Advisories 🚨

🚨 Percent-encoded cookies can be used to overwrite existing prefixed cookie names

It is possible to forge a secure or host-only cookie prefix in Rack using
an arbitrary cookie write by using URL encoding (percent-encoding) on the
name of the cookie. This could result in an application that is dependent on
this prefix to determine if a cookie is safe to process being manipulated
into processing an insecure or cross-origin request.
This vulnerability has been assigned the CVE identifier CVE-2020-8184.

Versions Affected: rack < 2.2.3, rack < 2.1.4
Not affected: Applications which do not rely on __Host- and __Secure- prefixes to determine if a cookie is safe to process
Fixed Versions: rack >= 2.2.3, rack >= 2.1.4

Impact

An attacker may be able to trick a vulnerable application into processing an
insecure (non-SSL) or cross-origin request if they can gain the ability to write
arbitrary cookies that are sent to the application.

Workarounds

If your application is impacted but you cannot upgrade to the released versions or apply
the provided patch, this issue can be temporarily addressed by adding the following workaround:
module Rack
  module Utils
    module_function def parse_cookies_header(header)
      return {} unless header
      header.split(/[;] */n).each_with_object({}) do |cookie, cookies|
        next if cookie.empty?
        key, value = cookie.split('=', 2)
        cookies[key] = (unescape(value) rescue value) unless cookies.key?(key)
      end
    end
  end
end

🚨 Percent-encoded cookies can be used to overwrite existing prefixed cookie names

It is possible to forge a secure or host-only cookie prefix in Rack using
an arbitrary cookie write by using URL encoding (percent-encoding) on the
name of the cookie. This could result in an application that is dependent on
this prefix to determine if a cookie is safe to process being manipulated
into processing an insecure or cross-origin request.
This vulnerability has been assigned the CVE identifier CVE-2020-8184.

Versions Affected: rack < 2.2.3, rack < 2.1.4
Not affected: Applications which do not rely on __Host- and __Secure- prefixes to determine if a cookie is safe to process
Fixed Versions: rack >= 2.2.3, rack >= 2.1.4

Impact

An attacker may be able to trick a vulnerable application into processing an
insecure (non-SSL) or cross-origin request if they can gain the ability to write
arbitrary cookies that are sent to the application.

Workarounds

If your application is impacted but you cannot upgrade to the released versions or apply
the provided patch, this issue can be temporarily addressed by adding the following workaround:
module Rack
  module Utils
    module_function def parse_cookies_header(header)
      return {} unless header
      header.split(/[;] */n).each_with_object({}) do |cookie, cookies|
        next if cookie.empty?
        key, value = cookie.split('=', 2)
        cookies[key] = (unescape(value) rescue value) unless cookies.key?(key)
      end
    end
  end
end

🚨 Directory traversal in Rack::Directory app bundled with Rack

There was a possible directory traversal vulnerability in the Rack::Directory app
that is bundled with Rack.

Versions Affected: rack < 2.2.0
Not affected: Applications that do not use Rack::Directory.
Fixed Versions: 2.1.3, >= 2.2.0

Impact

If certain directories exist in a director that is managed by
Rack::Directory, an attacker could, using this vulnerability, read the
contents of files on the server that were outside of the root specified in the
Rack::Directory initializer.

Workarounds

Until such time as the patch is applied or their Rack version is upgraded,
we recommend that developers do not use Rack::Directory in their
applications.

🚨 Directory traversal in Rack::Directory app bundled with Rack

There was a possible directory traversal vulnerability in the Rack::Directory app
that is bundled with Rack.

Versions Affected: rack < 2.2.0
Not affected: Applications that do not use Rack::Directory.
Fixed Versions: 2.1.3, >= 2.2.0

Impact

If certain directories exist in a director that is managed by
Rack::Directory, an attacker could, using this vulnerability, read the
contents of files on the server that were outside of the root specified in the
Rack::Directory initializer.

Workarounds

Until such time as the patch is applied or their Rack version is upgraded,
we recommend that developers do not use Rack::Directory in their
applications.

Release Notes

2.2.2 (from changelog)

Fixed

Fix incorrect Rack::Request#host value. (#1591, @ioquatix)

Revert Rack::Handler::Thin implementation. (#1583, @jeremyevans)

Double assignment is still needed to prevent an "unused variable" warning. (#1589, @kamipo)

Fix to handle same_site option for session pool. (#1587, @kamipo)

2.2.1 (from changelog)

Fixed

Rework Rack::Request#ip to handle empty forwarded_for. (#1577, @ioquatix)

2.2.0 (from changelog)

SPEC Changes

rack.session request environment entry must respond to to_hash and return unfrozen Hash. (@jeremyevans)

Request environment cannot be frozen. (@jeremyevans)

CGI values in the request environment with non-ASCII characters must use ASCII-8BIT encoding. (@jeremyevans)

Improve SPEC/lint relating to SERVER_NAME, SERVER_PORT and HTTP_HOST. (#1561, @ioquatix)

Added

rackup supports multiple -r options and will require all arguments. (@jeremyevans)

Server supports an array of paths to require for the :require option. (@khotta)

Files supports multipart range requests. (@fatkodima)

Multipart::UploadedFile supports an IO-like object instead of using the filesystem, using :filename and :io options. (@jeremyevans)

Multipart::UploadedFile supports keyword arguments :path, :content_type, and :binary in addition to positional arguments. (@jeremyevans)

Static supports a :cascade option for calling the app if there is no matching file. (@jeremyevans)

Session::Abstract::SessionHash#dig. (@jeremyevans)

Response.[] and MockResponse.[] for creating instances using status, headers, and body. (@ioquatix)

Convenient cache and content type methods for Rack::Response. (#1555, @ioquatix)

Changed

Request#params no longer rescues EOFError. (@jeremyevans)

Directory uses a streaming approach, significantly improving time to first byte for large directories. (@jeremyevans)

Directory no longer includes a Parent directory link in the root directory index. (@jeremyevans)

QueryParser#parse_nested_query uses original backtrace when reraising exception with new class. (@jeremyevans)

ConditionalGet follows RFC 7232 precedence if both If-None-Match and If-Modified-Since headers are provided. (@jeremyevans)

.ru files supports the frozen-string-literal magic comment. (@eregon)

Rely on autoload to load constants instead of requiring internal files, make sure to require 'rack' and not just 'rack/...'. (@jeremyevans)

Etag will continue sending ETag even if the response should not be cached. (@henm)

Request#host_with_port no longer includes a colon for a missing or empty port. (@AlexWayfer)

All handlers uses keywords arguments instead of an options hash argument. (@ioquatix)

Files handling of range requests no longer return a body that supports to_path, to ensure range requests are handled correctly. (@jeremyevans)

Multipart::Generator only includes Content-Length for files with paths, and Content-Disposition filename if the UploadedFile instance has one. (@jeremyevans)

Request#ssl? is true for the wss scheme (secure websockets). (@jeremyevans)

Rack::HeaderHash is memoized by default. (#1549, @ioquatix)

Rack::Directory allow directory traversal inside root directory. (#1417, @ThomasSevestre)

Sort encodings by server preference. (#1184, @ioquatix, @wjordan)

Rework host/hostname/authority implementation in Rack::Request. #host and #host_with_port have been changed to correctly return IPv6 addresses formatted with square brackets, as defined by RFC3986. (#1561, @ioquatix)

Rack::Builder parsing options on first #\ line is deprecated. (#1574, @ioquatix)

Removed

Directory#path as it was not used and always returned nil. (@jeremyevans)

BodyProxy#each as it was only needed to work around a bug in Ruby <1.9.3. (@jeremyevans)

URLMap::INFINITY and URLMap::NEGATIVE_INFINITY, in favor of Float::INFINITY. (@ch1c0t)

Deprecation of Rack::File. It will be deprecated again in rack 2.2 or 3.0. (@rafaelfranca)

Support for Ruby 2.2 as it is well past EOL. (@ioquatix)

Remove Rack::Files#response_body as the implementation was broken. (#1153, @ioquatix)

Remove SERVER_ADDR which was never part of the original SPEC. (#1573, @ioquatix)

Fixed

Directory correctly handles root paths containing glob metacharacters. (@jeremyevans)

Cascade uses a new response object for each call if initialized with no apps. (@jeremyevans)

BodyProxy correctly delegates keyword arguments to the body object on Ruby 2.7+. (@jeremyevans)

BodyProxy#method correctly handles methods delegated to the body object. (@jeremyevans)

Request#host and Request#host_with_port handle IPv6 addresses correctly. (@AlexWayfer)

Lint checks when response hijacking that rack.hijack is called with a valid object. (@jeremyevans)

Response#write correctly updates Content-Length if initialized with a body. (@jeremyevans)

CommonLogger includes SCRIPT_NAME when logging. (@Erol)

Utils.parse_nested_query correctly handles empty queries, using an empty instance of the params class instead of a hash. (@jeremyevans)

Directory correctly escapes paths in links. (@yous)

Request#delete_cookie and related Utils methods handle :domain and :path options in same call. (@jeremyevans)

Request#delete_cookie and related Utils methods do an exact match on :domain and :path options. (@jeremyevans)

Static no longer adds headers when a gzipped file request has a 304 response. (@chooh)

ContentLength sets Content-Length response header even for bodies not responding to to_ary. (@jeremyevans)

Thin handler supports options passed directly to Thin::Controllers::Controller. (@jeremyevans)

WEBrick handler no longer ignores :BindAddress option. (@jeremyevans)

ShowExceptions handles invalid POST data. (@jeremyevans)

Basic authentication requires a password, even if the password is empty. (@jeremyevans)

Lint checks response is array with 3 elements, per SPEC. (@jeremyevans)

Support for using :SSLEnable option when using WEBrick handler. (Gregor Melhorn)

Close response body after buffering it when buffering. (@ioquatix)

Only accept ; as delimiter when parsing cookies. (@mrageh)

Utils::HeaderHash#clear clears the name mapping as well. (@raxoft)

Support for passing nil Rack::Files.new, which notably fixes Rails' current ActiveStorage::FileServer implementation. (@ioquatix)

Documentation

CHANGELOG updates. (@aupajo)

Added CONTRIBUTING. (@dblock)

2.1.2 (from changelog)

Fix multipart parser for some files to prevent denial of service (@aiomaster)

Fix Rack::Builder#use with keyword arguments (@kamipo)

Skip deflating in Rack::Deflater if Content-Length is 0 (@jeremyevans)

Remove SessionHash#transform_keys, no longer needed (@pavel)

Add to_hash to wrap Hash and Session classes (@oleh-demyanyuk)

Handle case where session id key is requested but missing (@jeremyevans)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@depfu rebase
Rebases against your default branch and redoes this update

@depfu recreate
Recreates this PR, overwriting any edits that you've made to it

@depfu merge
Merges this PR once your tests are passing and conflicts are resolved

@depfu close
Closes this PR and deletes the branch

@depfu reopen
Restores the branch and reopens this PR (if it's closed)

@depfu pause
Ignores all future updates for this dependency and closes this PR

@depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR

@depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

Update better_errors to version 2.9.1

22f48d6

depfu bot added the depfu label Sep 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🚨 [security] Update better_errors: 2.5.1 → 2.9.1 (minor) #116

🚨 [security] Update better_errors: 2.5.1 → 2.9.1 (minor) #116

depfu bot commented Sep 14, 2021

🚨 [security] Update better_errors: 2.5.1 → 2.9.1 (minor) #116

Are you sure you want to change the base?

🚨 [security] Update better_errors: 2.5.1 → 2.9.1 (minor) #116

Conversation

depfu bot commented Sep 14, 2021

What changed?

✳️ better_errors (2.5.1 → 2.9.1) · Repo · Changelog

Impact

Patches

Workarounds

References

For more information

↗️ coderay (indirect, 1.1.2 → 1.1.3) · Repo · Changelog

↗️ erubi (indirect, 1.9.0 → 1.10.0) · Repo · Changelog

1.10.0 (from changelog)

↗️ rack (indirect, 2.1.1 → 2.2.3) · Repo · Changelog

Impact

Workarounds

Impact

Workarounds

Impact

Workarounds

Impact

Workarounds

2.2.2 (from changelog)

Fixed

2.2.1 (from changelog)

Fixed

2.2.0 (from changelog)

SPEC Changes

Added

Changed

Removed

Fixed

Documentation

2.1.2 (from changelog)