-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature zoom focus tracking #322
Conversation
Thanks for the PR. Are you aware of #320? I'm just worried you might run into conflicts given you're both working on camera things. |
Thanks for good news . I have read #320 I'm not worried about this PR. These 2 PR should be able to combine because the functions are not duplicated. |
Maybe a question for @julianoes here: how much do those functions overlap with camera params? Is it expected to have an API here for some params, but not all? |
@JonasVautherin I think it's depend on camera model some camera payload doesn't support Mavlink command they may not be able to use this feature either. |
@JonasVautherin zoom and focus are not implemented using parameters but standardized commands: So I think this is ok. |
I know at least two cameras that have zoom and/or focus in the camera definition 😇. The only one that the specs say must be implemented with a message is I guess that's part of the MAVLink specs: the user should try to detect (or hardcode) the camera and then hardcode the correct behavior 🙈. |
Yer zoom was added later, as was focus. |
433301a
to
5c80829
Compare
Signed-off-by: Julian Oes <[email protected]>
5c80829
to
6690bb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've edited this a bit. I added the units, and removed the redundant camera prefix.
From this PR -> mavlink/MAVSDK#2094 (comment)
This repository add the camera function to proto