Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature zoom focus tracking #322

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

aminballoon
Copy link
Contributor

From this PR -> mavlink/MAVSDK#2094 (comment)
This repository add the camera function to proto

@julianoes
Copy link
Collaborator

Thanks for the PR. Are you aware of #320? I'm just worried you might run into conflicts given you're both working on camera things.

@aminballoon
Copy link
Contributor Author

Thanks for good news . I have read #320 I'm not worried about this PR. These 2 PR should be able to combine because the functions are not duplicated.

@JonasVautherin
Copy link
Collaborator

Maybe a question for @julianoes here: how much do those functions overlap with camera params? Is it expected to have an API here for some params, but not all?

@aminballoon
Copy link
Contributor Author

@JonasVautherin I think it's depend on camera model some camera payload doesn't support Mavlink command they may not be able to use this feature either.

@julianoes
Copy link
Collaborator

@JonasVautherin zoom and focus are not implemented using parameters but standardized commands:
https://mavlink.io/en/messages/common.html#MAV_CMD_SET_CAMERA_ZOOM
https://mavlink.io/en/messages/common.html#MAV_CMD_SET_CAMERA_FOCUS

So I think this is ok.

@JonasVautherin
Copy link
Collaborator

JonasVautherin commented Jun 30, 2023

I know at least two cameras that have zoom and/or focus in the camera definition 😇. The only one that the specs say must be implemented with a message is CAM_MODE, I think. But of course they don't say that those two messages should not be used.

I guess that's part of the MAVLink specs: the user should try to detect (or hardcode) the camera and then hardcode the correct behavior 🙈.

@julianoes
Copy link
Collaborator

Yer zoom was added later, as was focus.

@julianoes julianoes force-pushed the add_feature/camera branch from 433301a to 5c80829 Compare March 18, 2024 17:34
@julianoes julianoes force-pushed the add_feature/camera branch from 5c80829 to 6690bb8 Compare March 18, 2024 18:11
Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've edited this a bit. I added the units, and removed the redundant camera prefix.

@julianoes julianoes merged commit 211476a into mavlink:main Mar 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants