Split Ftp plugin into Ftp and FtpServer #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
force-pushed
the
pr-split-ftp
branch
3 times, most recently
from
7bc561d to
65d7a6d
Compare
|
Oh, right. I was going to pull these commits out when I clean it up. |
|
I'm still hunting a crash in CI that I can't replicate... |
This was referenced Aug 7, 2023
julianoes
force-pushed
the
pr-split-ftp
branch
11 times, most recently
from
b41f172 to
488e6a5
Compare
julianoes
force-pushed
the
pr-split-ftp
branch
3 times, most recently
from
7224a85 to
f964fa1
Compare
julianoes
force-pushed
the
pr-split-ftp
branch
from
a385e04 to
de9b747
Compare
julianoes
force-pushed
the
pr-split-ftp
branch
from
988d8ff to
c818a31
Compare
julianoes
changed the title
julianoes
force-pushed
the
pr-split-ftp
branch
2 times, most recently
from
71bae31 to
fbbe947
Compare
This includes: - Refactor of server and client - Slight API changes - Using std::filesystem as much as possible everywhere. - Adding system tests Signed-off-by: Julian Oes <[email protected]>
This is to get more information about segfaults in CI. Signed-off-by: Julian Oes <[email protected]>
No need for 2 separate runners. Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
It turns out stack smashing seems to happen in create_temp_file, for whatever reason. This is a very desperate attempt to try to avoid it. Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
Signed-off-by: Julian Oes <[email protected]>
julianoes
force-pushed
the
pr-split-ftp
branch
4 times, most recently
from
25f8f98 to
a890302
Compare
Somehow these often segfault. I've spent days on this, and have to give up. Signed-off-by: Julian Oes <[email protected]>
julianoes
force-pushed
the
pr-split-ftp
branch
from
a890302 to
d1ec125
Compare
JonasVautherin
previously approved these changes
Nov 2, 2023
It now depends on the incoming FTP messages. Signed-off-by: Julian Oes <[email protected]>
QGC requests paths with a leading /. If we just remove it, that works inside of the defined root path. Signed-off-by: Julian Oes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FTP plugin is a weird combination of client and server in one. Now that we have Components additional to Systems we can split it into client and server.
This includes:
Depended on mavlink/MAVSDK-Proto#319.