Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.4] Downgrade Python to 3.11 for macOS CI builds #2182

Merged
merged 3 commits into from
Nov 19, 2023

Conversation

JonasVautherin
Copy link
Collaborator

Backporting #2179

@JonasVautherin
Copy link
Collaborator Author

JonasVautherin commented Nov 15, 2023

Hmm CMake keeps detecting 3.12 🤔:

-- Found Python3: /usr/local/bin/python3.12 (found version "3.12.0") found components: Interpreter

I think that it works for the runner 20230921.1, but not for 20231029.1. Some changes there:

  • CMake 3.27.6 -> 3.27.7
  • Python 3.11.5 -> 3.12.0

I can't explain why it seems to work in main and not in v1.4 yet.

@JonasVautherin
Copy link
Collaborator Author

JonasVautherin commented Nov 15, 2023

Oh, v1.4 uses CMake to detect Python:

find_package(Python3 COMPONENTS Interpreter REQUIRED)

main does not. Maybe something in this patch should be backported.

@julianoes
Copy link
Collaborator

I think this is missing: https://github.com/mavlink/MAVSDK/blob/04e78f163d3dd630103a353cca8d04fd943f8486/third_party/mavlink/mavlink.patch

@JonasVautherin
Copy link
Collaborator Author

Ok let's see. In the current CI run, iOS has the older runner image, and macOS has the new one. If your latest suggestion fixes it, both should work 👍.

@JonasVautherin
Copy link
Collaborator Author

Seems better! Good catch @julianoes!

@JonasVautherin
Copy link
Collaborator Author

Now Windows breaks 🙈. Retrying with set(Python_FIND_REGISTRY "NEVER") for Windows, which was the old value.

@JonasVautherin JonasVautherin force-pushed the v1.4-ci-python-3.11 branch 2 times, most recently from cf4d800 to 7acbbd1 Compare November 16, 2023 12:58
@julianoes julianoes merged commit f8a4cc0 into v1.4 Nov 19, 2023
29 checks passed
@julianoes julianoes deleted the v1.4-ci-python-3.11 branch November 19, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants