Full gimbal angle control #2210
Conversation
| void GimbalProtocolV2::set_pitch_and_yaw_async( | ||
| float pitch_deg, float yaw_deg, Gimbal::ResultCallback callback) | ||
| { | ||
| // Sending the message should be quick and we can just do that straighaway. | ||
| Gimbal::Result result = set_pitch_and_yaw(pitch_deg, yaw_deg); | ||
| Gimbal::Result result = set_angles(pitch_deg, yaw_deg, 0.0f); |
There was a problem hiding this comment.
Onto why the gtest changed, I did not pay attention when it happened. It could be that I messed up.
There was a problem hiding this comment.
If you do an interactive rebase you should be able to edit and amend that commit. Or you can just undo it again in a commit.
|
The gtest should now be back to the version used in the original MAVSDK repository. |
.gitmodules
Outdated
| @@ -3,4 +3,4 @@ | |||
| url = https://github.com/google/googletest | |||
| [submodule "mavsdk-proto"] | |||
| path = proto | |||
| url = https://github.com/mavlink/MAVSDK-Proto.git | |||
| url = https://github.com/Daybreakerflint/MAVSDK-Proto | |||
There was a problem hiding this comment.
Let me merge the MAVSDK-Proto PR, then you can update that and we can merge it.
Signed-off-by: Julian Oes <[email protected]>
Worth mentioning what the example is about. Signed-off-by: Julian Oes <[email protected]>
|
I've fixed this up, pointing to the right proto hash (after the merge) and running the style fix again. Thanks @Daybreakerflint! |
|
No problem. Our project really needs it. Also thank you for guiding me through my first PR! |
|
Let me trigger a new release. No reason not to :). And then Python sometime next week. |
|
Released: https://github.com/mavlink/MAVSDK-Python/releases/tag/2.0.0 |
Implementation of the full gimbal angle control
This feature is a request as I have to use the gimbal I have in a certain way and the roll and pitch axis are switched.
As the pitch of the payload of the gimbal is vitally important, this feature is needed.
I have tested the new implementation and it fully works.
Proto PR:
mavlink/MAVSDK-Proto#328
Quick note from my side: This is the first time I have done something like this and thus I am completely new to the process or anything. If I have done something wrong, let me know. I like to improve.