Events plugin #2338
Merged
Events plugin #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkueng
force-pushed
the
events
branch
3 times, most recently
from
dfa7422 to
4703ec2
Compare
julianoes
reviewed
Jun 14, 2024
| if(NOT MSVC) | ||
| add_compile_options(component_metadata PRIVATE -Wall -Wextra) | ||
| else() | ||
| add_compile_options(component_metadata PRIVATE -WX -W2) |
Comment on lines
+103
to
+107
| std::cout << "All Reports:" << std::endl; | ||
| for (const auto& problem : report.all_problems) { | ||
| std::cout << " [" << problem.log_level << "] [" << problem.health_component | ||
| << "]: " << problem.message << std::endl; | ||
| } |
There was a problem hiding this comment.
Amazing, that's great to have!
| @@ -82,11 +82,11 @@ TEST_F(CurlTest, Curl_DownloadFile_WithoutProgressFeedback_FileNotFound) | |||
| TEST_F(CurlTest, Curl_DownloadFile_ProgressFeedback_Success) | |||
| { | |||
| int last_progress; | |||
| Status last_status; | |||
| HttpStatus last_status; | |||
Comment on lines
+27
to
+37
| message(STATUS "Preparing external project \"libevents\" with args:") | ||
| foreach(CMAKE_ARG ${CMAKE_ARGS}) | ||
| message(STATUS "-- ${CMAKE_ARG}") | ||
| endforeach() | ||
|
|
||
| ExternalProject_Add( | ||
| libevents | ||
| GIT_REPOSITORY https://github.com/mavlink/libevents.git | ||
| GIT_TAG 9474657606d13301d426e044450c4f84de2221be | ||
| SOURCE_SUBDIR libs/cpp | ||
| CMAKE_ARGS "${CMAKE_ARGS}" |
There was a problem hiding this comment.
Awesome, that seems pretty clean like that!
There was a problem hiding this comment.
Thanks, I spent a bit of time fiddling with cmake until it all worked.
| @@ -1,5 +1,6 @@ | |||
| #include "integration_test_helper.h" | |||
| #include "mavsdk.h" | |||
| #include <algorithm> | |||
android-x86 had some unrelated request timeout, let's see if it passes now. |
|
|
Looks like just a fix_style required now... |
|
I think it's because the proto submodule isn't merged/updated yet. At least when I ran it last I didn't get any diff. |
When moving the component metadata to core, the following error was raised:
MAVSDK/src/mavsdk/plugins/camera/camera.cpp:18:7: error: conflicting declaration ‘using mavsdk::Status = struct mavsdk::Camera::Status’
18 | using Status = Camera::Status;
| ^~~~~~
In file included from MAVSDK/src/mavsdk/core/curl_wrapper.h:6,
from MAVSDK/src/mavsdk/core/http_loader.h:9,
from MAVSDK/src/mavsdk/core/mavlink_component_metadata.h:5,
from MAVSDK/src/mavsdk/core/system_impl.h:5,
from MAVSDK/src/mavsdk/core/plugin_impl_base.h:2,
from MAVSDK/src/mavsdk/plugins/camera/camera_impl.h:8,
from MAVSDK/src/mavsdk/plugins/camera/camera.cpp:7:
Small wrapper to create unique ID's. Avoids the need for MavsdkImpl and CallbackListImpl to have private access to Handle.
This follows mavlink_ftp_client, so that other plugins can access component metadata as well. The Plugin API remains unchanged.
Fixes errors in the form of: MAVSDK/src/mavsdk/core/call_every_handler.cpp:33:20: error: ‘find_if’ is not a member of ‘std’ This is with GCC 14.1.1
This is to avoid locking us out when doing subsequent downloads. For some reason this locked up on certain platforms.
|
Merged proto, rebased, fixed up and force pushed. Let's hope this clears CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings a plugin for the events protocol (https://mavlink.io/en/services/events.html), allowing to listen for events and arming checks.