AnalyzeView: LogDownloadController updates #11980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTRamsey
force-pushed
the
dev-analyzeview-logdownload
branch
from
97dd585 to
064d990
Compare
HTRamsey
force-pushed
the
dev-analyzeview-logdownload
branch
3 times, most recently
from
dd21add to
2f036e9
Compare
HTRamsey
force-pushed
the
dev-analyzeview-logdownload
branch
4 times, most recently
from
40008d8 to
d0f173a
Compare
HTRamsey
force-pushed
the
dev-analyzeview-logdownload
branch
from
d0f173a to
5473451
Compare
HTRamsey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanup
re-enable unit test
make LogDownloadController persistent when not in AnalyzeView page
Work to follow includes:
add select all button
resolving #4656 by using worker thread
registering LogDownloadController via QML_SINGLETON & CMake qml module