Only show displayed modes editor in Advanced Mode #12197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hides the "Edit Displayed Flight Modes" option found in the expanded mode selector dropdown menu unless Advanced Mode is on. Also hides the "Some Modes Hidden" text below the mode list under the same condition.
|
I'm not sure this is a good idea. It's a nice feature to be able to customized the set of flight modes the user wants to use. Custom builds can already remove the flights modes they want to exposed using the FirmwarePlugin::flightModes override. |
True, you're right |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only show displayed modes editor in Advanced Mode
Description
Hides the "Edit Displayed Flight Modes" option found in the expanded mode selector dropdown menu unless Advanced Mode is on. Also hides the "Some Modes Hidden" text below the mode list under the same condition.
When not in advanced mode, a user probably shouldn't have the option to select advanced modes such as Autotune or Circle, or even know that they're hidden.
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.