Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 and Monolog V3 #109

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

PHP 8.1 and Monolog V3 #109

wants to merge 10 commits into from

Conversation

maxbanton
Copy link
Owner

No description provided.

@coveralls
Copy link

coveralls commented Nov 7, 2022

Coverage Status

Coverage increased (+0.2%) to 91.589% when pulling daa70e3 on feature/php-8.1 into 7ad7477 on master.

@jelledijkstra97
Copy link

Would be great if you could merge this. Cannot use this package on Laravel 10 now.

@magnetas
Copy link

Would be great if you could merge this. Cannot use this package on Laravel 10 now.

I’m requiring this branch instead of tag/version temporarily in my Laravel 10 project and it works fine.

@markinjapan
Copy link

Nice idea! Works in my Slim 4 project too. In case it helps anyone, this command will do the job:
composer require maxbanton/cwh:dev-feature/php-8.1

To revert to the latest release, simply use:
composer require maxbanton/cwh

$batchSize = 10000,
string $group,
string $stream,
int $retention = 14,
Copy link

@noahred16 noahred16 Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought retention could be null for infinite. So that'd be ?int

Copy link

@markinjapan markinjapan Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noahred16 Apologies but many months ago I forked this repository and applied the above PR, with additional fixes and improvements. It's available at phpnexus/cwh.

I intend to maintain my fork as I use CloudWatch Logs with PHP 8.1 at my workplace, but may I ask if you plan to take over maintenance of this original repository?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @markinjapan. No, I just started using CloudWatch with my project and found this repo useful. I commented here but I did not realize that this repo was inactive. I'll take a look at yours. Thanks for sharing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants