Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: ODS Drop Primary Keys from NEW Tables #34

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

rymarczy
Copy link
Contributor

The CUBIC ODS RDS is Oracle which allows for the use of NULLABLE primary key columns.

This issue was originally found when attempting to ingest the EDW.PAYMENT_SUMMARY table, which contained NULL values in primary key columns.

This change alters the way new tables are created. A standard Postgres primary key is no longer created for each table. Instead, an Index using primary key columns is created, which can be nullable.

This change should have no impact on existing tables and will only impact newly added tables. With this change we can now import the EDW.PAYMENT_SUMMARY table.

This was tested locally and EDW.PAYMENT_SUMMARY table was imported without error.

@rymarczy rymarczy requested a review from grejdi-mbta December 12, 2024 17:06
Copy link
Contributor

@grejdi-mbta grejdi-mbta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! I'd love for you to document it more. I guess the PR description captures that. But I find that bringing that into the code as a comment would be better.

@rymarczy
Copy link
Contributor Author

Excellent! I'd love for you to document it more. I guess the PR description captures that. But I find that bringing that into the code as a comment would be better.

Incorporated

@rymarczy rymarczy merged commit 544bc9a into main Dec 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants